Skip to content

Conversation

@pawelgrochowicz
Copy link
Contributor

This PR adds OpenLineage support for CloudDataFusionStartPipelineOperator.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 12, 2025
@potiuk
Copy link
Member

potiuk commented Sep 12, 2025

Compat issue, but generally looks fine.

@pawelgrochowicz pawelgrochowicz marked this pull request as draft September 15, 2025 19:56
@pawelgrochowicz pawelgrochowicz marked this pull request as ready for review September 15, 2025 20:18
@pawelgrochowicz
Copy link
Contributor Author

@mobuchowski, FYI

Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, looks good overall

@mobuchowski
Copy link
Contributor

@pawelgrochowicz I think you need to rebase your PRs, there are some issues that look unrelated but fail the CI

@eladkal eladkal force-pushed the feat-ol-cloud-data-fusion-start-pipeline-operator branch from b1bf76b to 9a0d91c Compare October 1, 2025 11:09
@eladkal
Copy link
Contributor

eladkal commented Oct 1, 2025

rebased. lets see

@pawelgrochowicz pawelgrochowicz force-pushed the feat-ol-cloud-data-fusion-start-pipeline-operator branch from 9a0d91c to 57825d0 Compare October 1, 2025 14:35
@pawelgrochowicz pawelgrochowicz force-pushed the feat-ol-cloud-data-fusion-start-pipeline-operator branch from 57825d0 to 79e802b Compare October 2, 2025 20:47
@pawelgrochowicz
Copy link
Contributor Author

@mobuchowski, rebased and now checks are good

kevinhongzl and others added 6 commits October 3, 2025 15:56
…#56162)

* fix: allow mapped tasks to accept zero-length inputs on rerun

* fix: add test for rerun args of different length

* chore: revise comments to align with the changes

* chore: add comments before the task state check

* fix: replace legacy query syntax
* make the variable name in .Values.dags.gitSync.credentials secret dependent on the GitSync version

* update gitsync tests
Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com>
@mobuchowski
Copy link
Contributor

@pawelgrochowicz merged previous PR and now it has conflicts to fix :)

…ttps://github.com/pawelgrochowicz/airflow into feat-ol-cloud-data-fusion-start-pipeline-operator

# Conflicts:
#	providers/google/src/airflow/providers/google/cloud/openlineage/facets.py
#	providers/google/tests/unit/google/cloud/openlineage/test_facets.py
@mobuchowski
Copy link
Contributor

@pawelgrochowicz I think some git error happened here, there are unrelated commits included in this PR

@pawelgrochowicz
Copy link
Contributor Author

As this PR has been too messy, I closed this one and created a new one with just my code #56365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants