Simplify serve_logs IPv4/v6 binding #55716
Merged
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
ashb
added
the
changelog:skip
kaxil
pushed a commit
that referenced
this pull request
Sep 16, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes #55470 (cherry picked from commit 9ff753d)
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes apache#55470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to be "smart" about what interface we listened on, but that
isn't really needed, and passing an empty host achieves the same effect:
The existing approach was working fine for most people (including myself) it
was working fine and listening on ipv6 and v4 wildcard interfaces as expected,
but some Docker/container set ups this was not the case, and despite Dualstack
saying True, listening on
::ended up only listening on IPv6, but theentry in
/etc/hostsin the container only had an entry for the IPv4 addressof the pod, which we weren't listening on, so log requests would fail.
Which is all a round about way of saying "doing less works better" 😀
(We also don't need the getattr+lambda anymore, as that was to support Python
<= 3.7!)
Fixes #55470