-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Respect old logging format if given so logs don't change unexpectedly. #55824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
f85385f to
163ceec
Compare
eladkal
approved these changes
Sep 18, 2025
kaxil
approved these changes
Sep 18, 2025
kaxil
pushed a commit
that referenced
this pull request
Sep 18, 2025
#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed. (cherry picked from commit 0ec7b0f)
Contributor
|
Hey @ashb! It seems like environment variable overrides and TTY check are not working anymore because Here's the overrides and TTY check I'm talking about: airflow/shared/logging/src/airflow_shared/logging/structlog.py Lines 404 to 434 in 6f1a20f
|
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 26, 2025
… env variables After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. Resolves apache#56114
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 26, 2025
… env variables After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. Resolves apache#56114
ashb
pushed a commit
that referenced
this pull request
Sep 26, 2025
… env variables (#56132) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ort override env variables (#56132) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. (cherry picked from commit d08c2d2) Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
ashb
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ort override env variables (#56132) (#56157) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. (cherry picked from commit d08c2d2) Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
apache#55824) If someone is upgrading from any earlier version, their config file with have `log_format` in it, even though we have now changed the default to an empty string. This also makes respects the colored_console_log config option If it is specified we should respect it, even though our new default has changed.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone is upgrading from any earlier version, their config file with have
log_formatin it, even though we have now changed the default to an emptystring.
This also makes respects the colored_console_log config option
If it is specified we should respect it, even though our new default has
changed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.