Detect interactive terminal to set colored logging + support override env variables #56132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… env variables After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. Resolves apache#56114
Contributor
Author
|
cc @ashb |
ashb
approved these changes
Sep 26, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ort override env variables (#56132) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. (cherry picked from commit d08c2d2) Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
Backport successfully created: v3-1-test
|
ashb
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ort override env variables (#56132) (#56157) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. (cherry picked from commit d08c2d2) Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
… env variables (apache#56132) After apache#55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected.
This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored.
Resolves #56114
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.