Skip to content

Conversation

@Zeglow
Copy link

@Zeglow Zeglow commented Sep 19, 2025

  • Add proper relabeling for Airbyte-specific field meanings
  • Ensure 'login' displays as 'Client ID' and 'password' as 'Client Secret'
  • Similar pattern to other provider fixes

Closes #55841

截屏2025-09-18 22 14 12

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

- Add proper relabeling for Airbyte-specific field meanings
- Ensure 'login' displays as 'Client ID' and 'password' as 'Client Secret'
- Similar pattern to other provider fixes

Closes apache#55841
- Test that correct fields are hidden (extra, port)
- Test that proper relabeling is applied:
  - host -> Server URL
  - login -> Client ID
  - password -> Client Secret
  - schema -> Token URL
- Test that placeholders is empty
- Ensures the UI field behavior works correctly for Airbyte connections
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 19, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jedcunningham
Copy link
Member

Hi @Zeglow, thanks for the PR!

In the future, when looking for issues to work on, please note whether the issue is already assigned to someone - that person has raised their hand to work on it and may be actively working on it already. If it's been a while since the assignment, you can always ask in the issue if they still plan to work on it - that is completely fair. Hope that makes sense. Thanks.

@Zeglow
Copy link
Author

Zeglow commented Sep 19, 2025

Hi @Zeglow, thanks for the PR!

In the future, when looking for issues to work on, please note whether the issue is already assigned to someone - that person has raised their hand to work on it and may be actively working on it already. If it's been a while since the assignment, you can always ask in the issue if they still plan to work on it - that is completely fair. Hope that makes sense. Thanks.

Hi @jedcunningham, thanks a lot for pointing that out! This is actually my first time contributing to an open-source project, so I really appreciate the guidance. I’ll make sure to check in the future. Thanks again for the reminder — I’m excited to keep learning and contributing : )

@jedcunningham
Copy link
Member

No problem, welcome to the community 🍺

@eladkal eladkal requested a review from jason810496 September 28, 2025 08:54
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

The static check CI still need fix:

# install prek
uv tool install prek 

# fix the formatting 
prek ruff --all-files && prek run ruff-format --all-files

Comment on lines +240 to +243
assert relabeling["host"] == "Server URL"
assert relabeling["login"] == "Client ID"
assert relabeling["password"] == "Client Secret"
assert relabeling["schema"] == "Token URL"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How about just assert the whole field_behaviour with dictionary? Maybe it be more straightforward for the test case.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 15, 2025
@github-actions github-actions bot closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:airbyte stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airbyte Connection Required Fields missing on Airflow 3

3 participants