-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix: Make Airbyte connection fields properly labeled in Airflow 3 #55869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add proper relabeling for Airbyte-specific field meanings - Ensure 'login' displays as 'Client ID' and 'password' as 'Client Secret' - Similar pattern to other provider fixes Closes apache#55841
- Test that correct fields are hidden (extra, port) - Test that proper relabeling is applied: - host -> Server URL - login -> Client ID - password -> Client Secret - schema -> Token URL - Test that placeholders is empty - Ensures the UI field behavior works correctly for Airbyte connections
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Hi @Zeglow, thanks for the PR! In the future, when looking for issues to work on, please note whether the issue is already assigned to someone - that person has raised their hand to work on it and may be actively working on it already. If it's been a while since the assignment, you can always ask in the issue if they still plan to work on it - that is completely fair. Hope that makes sense. Thanks. |
Hi @jedcunningham, thanks a lot for pointing that out! This is actually my first time contributing to an open-source project, so I really appreciate the guidance. I’ll make sure to check in the future. Thanks again for the reminder — I’m excited to keep learning and contributing : ) |
|
No problem, welcome to the community 🍺 |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR!
The static check CI still need fix:
# install prek
uv tool install prek
# fix the formatting
prek ruff --all-files && prek run ruff-format --all-files| assert relabeling["host"] == "Server URL" | ||
| assert relabeling["login"] == "Client ID" | ||
| assert relabeling["password"] == "Client Secret" | ||
| assert relabeling["schema"] == "Token URL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: How about just assert the whole field_behaviour with dictionary? Maybe it be more straightforward for the test case.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Closes #55841
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.