Fix airbyte connection UI #56174
Closed
Fix airbyte connection UI #56174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add proper relabeling for Airbyte-specific field meanings - Ensure 'login' displays as 'Client ID' and 'password' as 'Client Secret' - Similar pattern to other provider fixes Closes apache#55841
- Test that correct fields are hidden (extra, port) - Test that proper relabeling is applied: - host -> Server URL - login -> Client ID - password -> Client Secret - schema -> Token URL - Test that placeholders is empty - Ensures the UI field behavior works correctly for Airbyte connections
Author
|
Duplicate of #55869, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Make Airbyte connection fields properly labeled in Airflow 3
Fixes the formatting issue in
get_ui_field_behaviourmethod that was preventing proper field labeling for Airbyte connections in Airflow 3.Problem:
In Airflow 3, the Airbyte provider connection form shows generic field names (login, password, schema) instead of user-friendly labels (Client ID, Client Secret, Token URL), making it confusing for users to set up Airbyte connections.
Root Cause:
The
get_ui_field_behaviourmethod had incorrect formatting/indentation in therelabelingdictionary, causing the UI field relabeling functionality to fail silently.Solution:
relabelingdictionaryRead the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.