Skip to content

Update all models to use sqlalchemy 2 annotations #55954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vincbeck merged 1 commit into from
Sep 29, 2025
Merged

Update all models to use sqlalchemy 2 annotations #55954

vincbeck merged 1 commit into from
Sep 29, 2025

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Sep 22, 2025 •
edited
Loading

Update all models to use sqlalchemy 2 annotations. Keep it also backward compatible with SQLA 1.

This is required to switch to sqlalchemy 2.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/sqla2 branch 2 times, most recently from 3713477 to 6b26260 Compare September 22, 2025 17:31
@vincbeck vincbeck added the full tests needed We need to run full set of tests for this PR to merge label Sep 22, 2025
@vincbeck vincbeck closed this Sep 22, 2025
@vincbeck vincbeck reopened this Sep 22, 2025
Dev-iL
Dev-iL reviewed Sep 22, 2025
View reviewed changes
@vincbeck vincbeck force-pushed the vincbeck/sqla2 branch 5 times, most recently from 4880099 to 5da471b Compare September 23, 2025 15:01
@vincbeck vincbeck marked this pull request as ready for review September 23, 2025 15:02
@vincbeck vincbeck requested review from Dev-iL and dstandish and removed request for Dev-iL September 23, 2025 16:45
ashb
ashb reviewed Sep 24, 2025
View reviewed changes
ashb
ashb reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need to continue supporting SQLA1, or can we "simply" switch to 2.x and update the syntax at the same time?

@vincbeck
Copy link
Contributor Author

vincbeck commented Sep 25, 2025 •
edited
Loading

Question: do we need to continue supporting SQLA1, or can we "simply" switch to 2.x and update the syntax at the same time?

In order to switch to SQLA2 we need 2 things (the 2nd point can be split in 2, so let's say 3 points):

  1. Migrate to FAB 5. We need to have this PR merged: Upgrade FAB to FAB 5 #50960
  2. Resolve all static errors raised by mypy when SQLA2 is enabled. When SQLA2 is used, mypy is really angry and raises more than 900 errors. You can see some example of these errors in SQLA_Migration_Plan.md created by @Dev-iL
    a. Upgrading the models (this PR) resolves more than half
    b. Then we need to resolve them individually

We need to complete all these things in order to switch to SQLA2 so no I do not think and should not do that in the same PR.

@vincbeck vincbeck force-pushed the vincbeck/sqla2 branch 2 times, most recently from 9f1ac41 to 805f1db Compare September 25, 2025 19:02
@vincbeck vincbeck mentioned this pull request Sep 25, 2025
Merged
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
bfd362e
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
26f4c00 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
bf58ba5
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
b896426 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
7a5bb20
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
c7ac16d 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
cc7cad2
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
6eac1cb 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
91f98b2
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
dc970c0 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
362f4fa
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
3fafb88 
…5954)" (apache#56296)

This reverts commit 3150430.
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@vincbeck @dabla
Update all models to use sqlalchemy 2 annotations (apache#55954)
4778a04
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@vincbeck @dabla
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
0345626 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
9477ae5
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
9337cd5 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
ba2eefe
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
a95945e 
…5954)" (apache#56296)

This reverts commit 3150430.
vincbeck added a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 15, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
ead9028
@vincbeck vincbeck mentioned this pull request Oct 15, 2025
Merged
@vincbeck
Copy link
Contributor Author

vincbeck commented Oct 15, 2025

This PR was reverted because it made the CI fail. I finally could fix it and is available here: #56330. Any review is appreciated :)

potiuk pushed a commit that referenced this pull request Oct 15, 2025
@vincbeck
Update models to use SQLA2 annotations and synced model nullable cons…
5a2e95a 
…traints (#56330)

* Update all models to use `sqlalchemy` 2 annotations (#55954)

* Fix NULL constraints
snreddygopu pushed a commit to Teradata/airflow that referenced this pull request Oct 16, 2025
@vincbeck @sc250072
Update models to use SQLA2 annotations and synced model nullable cons…
feac8ad 
…traints (apache#56330)

* Update all models to use `sqlalchemy` 2 annotations (apache#55954)

* Fix NULL constraints
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
19d94d0
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
d050adf 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@vincbeck
Update models to use SQLA2 annotations and synced model nullable cons…
0723ecf 
…traints (apache#56330)

* Update all models to use `sqlalchemy` 2 annotations (apache#55954)

* Fix NULL constraints
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@vincbeck
Update all models to use sqlalchemy 2 annotations (apache#55954)
4bf5c8e
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@vincbeck
Revert "Update all models to use sqlalchemy 2 annotations (apache#5…
1fcbaaf 
…5954)" (apache#56296)

This reverts commit 3150430.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@vincbeck
Update models to use SQLA2 annotations and synced model nullable cons…
c1a7ebd 
…traints (apache#56330)

* Update all models to use `sqlalchemy` 2 annotations (apache#55954)

* Fix NULL constraints
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
@vincbeck @TyrellHaywood
Update models to use SQLA2 annotations and synced model nullable cons…
1bd200c 
…traints (apache#56330)

* Update all models to use `sqlalchemy` 2 annotations (apache#55954)

* Fix NULL constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@eladkal eladkal eladkal approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@dstandish dstandish Awaiting requested review from dstandish

@ashb ashb Awaiting requested review from ashb ashb is a code owner

+1 more reviewer

@Dev-iL Dev-iL Dev-iL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:serialization area:Triggerer full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vincbeck @Dev-iL @ashb @potiuk @eladkal