-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Update models to use SQLA2 annotations and synced model nullable constraints #56330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae7a557 to
98e7933
Compare
|
@pierrejeambrun @Dev-iL, I need your help here. In this PR I update all the models to use sqlalchemy 2 annotations. As part of this migration I also had to fix the different mismtaches between the database and models regarding the non-null constraints. But anyway, long story short is, I updated all the models to use sqlalchemy 2 annotations. All tests are passing but 3, only with python 3.13: See the full stack trace here. I do not quite understand the root cause. Surprisingly it fails only with patch APIs. If you have a bit of time, I'd appreciate if you can take a look and maybe you'll find out something I did not. |
98e7933 to
830e070
Compare
830e070 to
ba53b14
Compare
ba53b14 to
34829b9
Compare
|
I also added "all versions" to make sure that all python versions are tested. Closed/reopened to trigger it |
|
Green 🟢 |
…traints (apache#56330) * Update all models to use `sqlalchemy` 2 annotations (apache#55954) * Fix NULL constraints
…traints (apache#56330) * Update all models to use `sqlalchemy` 2 annotations (apache#55954) * Fix NULL constraints
…traints (apache#56330) * Update all models to use `sqlalchemy` 2 annotations (apache#55954) * Fix NULL constraints
…traints (apache#56330) * Update all models to use `sqlalchemy` 2 annotations (apache#55954) * Fix NULL constraints
This PR includes 2 changes (hence 2 commits):
sqlalchemy2 annotations #55954 before it got reverted in Revert "Update all models to usesqlalchemy2 annotations (#55954)" #56296nullableparameter with the annotation. That's the root cause why the CI started to fail after Update all models to usesqlalchemy2 annotations #55954 got merged.If you have already reviewed #55954, you need to review only the 2nd commit of this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.