Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4074] Cannot put labels on Cloud Dataproc jobs #5606

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Jul 18, 2019

Add option to add labels to Dataproc jobs.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just separate out the pylintrc change to separate PR. I also would like @BasPH to confirm that he is ok with this pylintrc change.

pylintrc Outdated Show resolved Hide resolved
Add option to add labels to Dataproc jobs.

fixup! [AIRFLOW-4074] Cannot put labels on Cloud Dataproc jobs
@turbaszek
Copy link
Member Author

@potiuk the pylintrc change was merged in #5586, are you ok with this PR?

@potiuk
Copy link
Member

potiuk commented Jul 20, 2019

Sure!

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Jul 22, 2019
@mik-laj mik-laj merged commit 4d58f36 into apache:master Jul 22, 2019
serkef pushed a commit to serkef/airflow that referenced this pull request Jul 24, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
@turbaszek turbaszek deleted the dataproc-pyspark-labels branch September 19, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants