[AIRFLOW-4074] Cannot put labels on Cloud Dataproc jobs

[turbaszek]

Add option to add labels to Dataproc jobs.

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-4074
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@6d78d7f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage          ?   79.11%           
=========================================
  Files             ?      489           
  Lines             ?    30691           
  Branches          ?        0           
=========================================
  Hits              ?    24280           
  Misses            ?     6411           
  Partials          ?        0

Impacted Files	Coverage Δ
airflow/contrib/hooks/gcp_dataproc_hook.py	61.84% <100%> (ø)
airflow/contrib/operators/dataproc_operator.py	86.18% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d78d7f...4229a62. Read the comment docs.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@6d78d7f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage          ?   79.11%           
=========================================
  Files             ?      489           
  Lines             ?    30692           
  Branches          ?        0           
=========================================
  Hits              ?    24281           
  Misses            ?     6411           
  Partials          ?        0

Impacted Files	Coverage Δ
airflow/contrib/hooks/gcp_dataproc_hook.py	62.06% <100%> (ø)
airflow/contrib/operators/dataproc_operator.py	86.18% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d78d7f...a1a1530. Read the comment docs.

[mik-laj]

To tag and track GCP resources spawned from Airflow, we have been adding airflow specific label(s) to GCP API service calls whenever possible and applicable. For example, we add “airflow-version” label to the dataproc cluster created. We expect new GCP service operators will also add Airflow top-level label “airflow-version” in addition to any service specific labels.

https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd#

WDYT?

[turbaszek]

To tag and track GCP resources spawned from Airflow, we have been adding airflow specific label(s) to GCP API service calls whenever possible and applicable. For example, we add “airflow-version” label to the dataproc cluster created. We expect new GCP service operators will also add Airflow top-level label “airflow-version” in addition to any service specific labels.

https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd#

WDYT?

I can see no info about client_info in REST API (now we use discovery API in Dataproc). However, when when we will use Python API there should be such possibility but I think transition to native API should be in other PR.

[mik-laj]

In case of Discovery API, we could use a code similar to Cloud Composer.
https://github.com/mik-laj/cloud-composer-releases/blob/0a75d37def26fb42e6a8a450b600e91efff5c915/airflow/contrib/hooks/gcp_api_base_hook.py#L134-L157
but that should not be part of this PR.
I would just like to say that we should add additional labels with the Airflow version.
Example:
https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/gcp_container_hook.py#L218

[mik-laj]

Another example:
https://github.com/apache/airflow/blob/master/airflow/contrib/operators/gcs_operator.py#L116-L119

[turbaszek]

Merged in apache#5606