Checkbox before clear task confirmation to prevent rerun of tasks in 'Running' states. #56351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning, up_for_retry, or restarting state.
…n confirmation dialogue.
…and ui still not communicating. MIGHT revert to previous commit.
…that will not run the instance until the instance is not running.
…o router. Followed suggestion about attribute access.
…nningTasks in dags.json in the en locale.
…ent_running_tasks' addition to ti, instead, it is passed as a parameter in clearTaskInstance.
…Error code 400 is still being raised in the router.
…f trying to clear a running task.
boring-cyborg
bot
added
area:API
kncatalan
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
…escript-eslint/no-unsafe-assignment
jason810496
reviewed
Nov 3, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
The unit test of airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py still need fix. Thanks!
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
…est to count prevent_running_task.
uranusjr
reviewed
Nov 4, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
jason810496
reviewed
Nov 5, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! LGMT on backend side if CI run successfully.
bbovenzi
reviewed
Nov 5, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Can you please upload new gifs and screenshots with the clear and then confirm dialog?
Contributor
Author
|
Here is a video of the behavior as of the current commit: chrome_YtNOT3EeU7.mp4Here is a video of the default behavior of the clear task instance when "prevent running task" is unchecked: chrome_7lcNOznlqs.mp4And here are the screenshots: |
jason810496
approved these changes
Nov 6, 2025
Contributor
Author
|
Hello! This comment is a friendly ping for a review whenever someone is free. Sorry for the sudden notification. |
bbovenzi
approved these changes
Nov 20, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
|
It seems that the recent changes in this PR introduced some TypeScript compilation errors and ESLint issues in Errors encountered: 
|
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…'Running' states. (apache#56351) * Added a confirm dialog modal that appears only when the task is in running, up_for_retry, or restarting state. * Removed unnecessary comments * Added clearTask texts in dags.json in the EN locale. Used translate in confirmation dialogue. * (NON-WORKING/ Experimental) added a flag in taskinstance.py. backend and ui still not communicating. MIGHT revert to previous commit. * (EXPERIMENTAL) Removed the confirm pop-up and replaced with checkbox that will not run the instance until the instance is not running. * Added mirgin-right auto for the checkbox * Change isRunning to task_confirmed_running. Moved the HTTPException to router. Followed suggestion about attribute access. * Made the checkbox checked on default. is_running_message set to true by default. * Added the code 400 to line 688. * Cleaned up the code and attempted to adress the error in the tests, e712. * Made sure the date variable is not null and changed the string in the value error * Changed the hardcoded english into an i18n translate. Added preventRunningTasks in dags.json in the en locale. * Renamed the is_running_message to prevent_running_tasks. Removed prevent_running_tasks' addition to ti, instead, it is passed as a parameter in clearTaskInstance. * Added a custom airflow exception for clearing running task instance. Error code 400 is still being raised in the router. * Added retry 0 in use clearTaskInstances. * Added a conditional for error toast that states the task is running if trying to clear a running task. * added check for null in error.detail * removed unnecessary imports in task_instances.py * made the prevent_running_task optional to pass checks * Changed prevent_running_task to Optional[bool]=None to be optional in test check * Attempt to resolve static checks which are unsafe assignment and calls in useClearTaskInstances, dateTimeUtils, and dateTimeUtils.test. * Added flag for QUEUED and SCHEDULED in taskinstances.py * Added a modal for QUEUED and SCHEDULED states. * Added the text of the modal in the en locale. * Changed the contents of the modal to include the user that started the task and the time when it was started. * Changed taskinstance.py according to the comments, and changed the modal behavior to only trigger the toast when task is running, not in queued or scheduled. * Attempt to resolve static checks * Attempt to resolve assertion errors of prevent_running_task = false in tests. * Attempt to fix the restarting state returned by clear_task_instances method. * 2nd Attempt to resolve static checks * Used common:error.defaultMessage for the default error toast. Added useState to avoid the modal rendering for a split second when its not supposed to. * Resolve the dateTimeUtils.getRelativeTime not returning an empty string when date is undefined. 3rd Attempt to solve static checks. * Attempt to resolve 7 eslint static checks error. Shortened conditional codes. * Resolving eslint errors in UseClearTaskInstance and ClearTaskInstanceConfirmationDialog. Implemented suggested changes. * Attempt to resolve detail in useClearTaskInstances not triggering typescript-eslint/no-unsafe-assignment * Attempt to resolve static checks. * Removed kwargs inspect, added back prevent_running_task, and edited test to count prevent_running_task. * Changed error code 400 to 409. Added the pre-commit modification. * Fixed missing detail in the error toast.
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…'Running' states. (apache#56351) * Added a confirm dialog modal that appears only when the task is in running, up_for_retry, or restarting state. * Removed unnecessary comments * Added clearTask texts in dags.json in the EN locale. Used translate in confirmation dialogue. * (NON-WORKING/ Experimental) added a flag in taskinstance.py. backend and ui still not communicating. MIGHT revert to previous commit. * (EXPERIMENTAL) Removed the confirm pop-up and replaced with checkbox that will not run the instance until the instance is not running. * Added mirgin-right auto for the checkbox * Change isRunning to task_confirmed_running. Moved the HTTPException to router. Followed suggestion about attribute access. * Made the checkbox checked on default. is_running_message set to true by default. * Added the code 400 to line 688. * Cleaned up the code and attempted to adress the error in the tests, e712. * Made sure the date variable is not null and changed the string in the value error * Changed the hardcoded english into an i18n translate. Added preventRunningTasks in dags.json in the en locale. * Renamed the is_running_message to prevent_running_tasks. Removed prevent_running_tasks' addition to ti, instead, it is passed as a parameter in clearTaskInstance. * Added a custom airflow exception for clearing running task instance. Error code 400 is still being raised in the router. * Added retry 0 in use clearTaskInstances. * Added a conditional for error toast that states the task is running if trying to clear a running task. * added check for null in error.detail * removed unnecessary imports in task_instances.py * made the prevent_running_task optional to pass checks * Changed prevent_running_task to Optional[bool]=None to be optional in test check * Attempt to resolve static checks which are unsafe assignment and calls in useClearTaskInstances, dateTimeUtils, and dateTimeUtils.test. * Added flag for QUEUED and SCHEDULED in taskinstances.py * Added a modal for QUEUED and SCHEDULED states. * Added the text of the modal in the en locale. * Changed the contents of the modal to include the user that started the task and the time when it was started. * Changed taskinstance.py according to the comments, and changed the modal behavior to only trigger the toast when task is running, not in queued or scheduled. * Attempt to resolve static checks * Attempt to resolve assertion errors of prevent_running_task = false in tests. * Attempt to fix the restarting state returned by clear_task_instances method. * 2nd Attempt to resolve static checks * Used common:error.defaultMessage for the default error toast. Added useState to avoid the modal rendering for a split second when its not supposed to. * Resolve the dateTimeUtils.getRelativeTime not returning an empty string when date is undefined. 3rd Attempt to solve static checks. * Attempt to resolve 7 eslint static checks error. Shortened conditional codes. * Resolving eslint errors in UseClearTaskInstance and ClearTaskInstanceConfirmationDialog. Implemented suggested changes. * Attempt to resolve detail in useClearTaskInstances not triggering typescript-eslint/no-unsafe-assignment * Attempt to resolve static checks. * Removed kwargs inspect, added back prevent_running_task, and edited test to count prevent_running_task. * Changed error code 400 to 409. Added the pre-commit modification. * Fixed missing detail in the error toast.
24 tasks
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This pull request is a revised version of the pull request #55660 and so it is also based on issue #54379
Why another PR?
Due to the changes made in the previous pull request ( #55660 ), its design has deviated from the original PR. Therefore, it necessitated a change in PR following the new design and interaction with the user.
This PR's goal is still the same compared to the last one, however, its execution is now a bit different as the modal is removed and is replaced by a checkbox. The checkbox still serves the same purpose to prevent a running task instance from clearing, but without necessitating the user to read another prompt/ pop-up, and urging the user to make the decision before the dialog confirm instead of after.
What
Difference of this PR compared to PR #55660 :
This PR uses the same code for the backend flag from #55660 to enable the functionalities of the checkbox.
Here is a video example of how the checkbox works:
chrome_VkmgN56gJw.mp4
Here is what happens when the checkbox is unchecked and goes back to the default behavior:
chrome_wbJuSnkObl.mp4