Skip to content

Conversation

@RoyLee1224
Copy link
Contributor

@RoyLee1224 RoyLee1224 commented Nov 21, 2025

Related

#56351

Why

TypeScript compilation errors and ESLint issues are currently causing the UI build to fail.
(Not sure how it passed CI 🤔)

image

Changes

  1. useClearTaskInstances.ts:
    • Removed the incorrect .body access on the error object (the error object structure is { detail: ... }, not { body: { detail: ... } }).
    • Resolved ESLint no-unnecessary-boolean-literal-compare error by removing === true.
    • Resolved ESLint object-shorthand error.
  2. ClearTaskInstanceConfirmationDialog.tsx:
    • Applied missing Prettier formatting (added braces to single-line if statement and sorted props).
  3. dags.json:
    • Sorted keys to satisfy the linter.

Testing

  • Ran pnpm lint:fix& pnpm format locally and confirmed no type errors.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
But I’m also wondering how the CI check passed

@guan404ming
Copy link
Member

The ci is outdated when the pr is merged.

@guan404ming guan404ming merged commit 6c853ff into apache:main Nov 21, 2025
63 checks passed
@Lee-W
Copy link
Member

Lee-W commented Nov 21, 2025

@guan404ming this kind of thing normally need to be backported to v3-1-test as well. let's add the label next time. Thanks! I'll do the manual backport forget about it I thought v3-1-test is the same error as this one. sorry for the confusion 🙇

@Lee-W Lee-W added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 21, 2025
@RoyLee1224 RoyLee1224 deleted the fix/ui-build-error branch November 22, 2025 01:00
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
* fix(ui): fix build failures in clear task instances

* fix: resolve lint errors
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
* fix(ui): fix build failures in clear task instances

* fix: resolve lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch translation:default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants