-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix UI build error #58545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI build error #58545
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
But I’m also wondering how the CI check passed
|
The ci is outdated when the pr is merged. |
|
@guan404ming |
* fix(ui): fix build failures in clear task instances * fix: resolve lint errors
* fix(ui): fix build failures in clear task instances * fix: resolve lint errors
Related
#56351
Why
TypeScript compilation errors and ESLint issues are currently causing the UI build to fail.
(Not sure how it passed CI 🤔)
Changes
useClearTaskInstances.ts:.bodyaccess on the error object (the error object structure is{ detail: ... }, not{ body: { detail: ... } }).no-unnecessary-boolean-literal-compareerror by removing=== true.object-shorthanderror.ClearTaskInstanceConfirmationDialog.tsx:ifstatement and sorted props).dags.json:Testing
pnpm lint:fix&pnpm formatlocally and confirmed no type errors.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.