Skip to content

fix: Add auto-refresh functionality to Required Actions page #56404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 7 commits into from
Oct 24, 2025
Merged

fix: Add auto-refresh functionality to Required Actions page #56404

pierrejeambrun merged 7 commits into from
Oct 24, 2025

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Oct 5, 2025 •
edited
Loading

related: #56081

  • This PR adds useAutoRefresh hook to HITLTaskInstances component
  • Pass refetchInterval to useTaskInstanceServiceGetHitlDetails query
  • Enable automatic refresh every 3 seconds for HITL task instances

We don't need to press refresh-key manually.

thanks for review.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 5, 2025
@rich7420
Copy link
Contributor Author

rich7420 commented Oct 9, 2025 •
edited
Loading

@bbovenzi thanks for the suggestion! I switched the fixed refetch interval to a conditional one:
auto‑refresh is enabled only when filtering with response_received=false. after each fetch, we check whether hitl_details still contains any items with no responded_at and state === 'deferred'. if none remain, we return false to stop polling.

@rich7420
Copy link
Contributor Author

rich7420 commented Oct 13, 2025

Thanks @bbovenzi , I removed effectiveResponseReceived only use the query.state.data

pierrejeambrun
pierrejeambrun approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 15, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.1 milestone Oct 15, 2025
pierrejeambrun
pierrejeambrun reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nit to fix before we can merge.

@kaxil kaxil modified the milestones: Airflow 3.1.1, Airflow 3.1.2 Oct 21, 2025
pierrejeambrun
pierrejeambrun reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing, do you mind fixing it so we can merge the PR.

@rich7420
Copy link
Contributor Author

rich7420 commented Oct 23, 2025

CI is still failing, do you mind fixing it so we can merge the PR.

No problem, I'll try! Thanks!

pierrejeambrun
pierrejeambrun approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! 🎉

@pierrejeambrun pierrejeambrun merged commit 9adb256 into apache:main Oct 24, 2025
56 checks passed
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 9adb256 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Oct 24, 2025
@rich7420 @bbovenzi @pierrejeambrun
fix: Add auto-refresh functionality to Required Actions page (apache#…
1d1e270 
…56404)

* Add auto-refresh functionality to Required Actions page

* switch refresh interval

* remove dependance of effectiveResponseReceived

* remove typescript error and comment

* fix static check error

* fix ts-compile-lint-ui error

---------

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 9adb256)
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Oct 24, 2025

Manual backport #57207

Lee-W pushed a commit that referenced this pull request Oct 27, 2025
@pierrejeambrun @rich7420 @bbovenzi
fix: Add auto-refresh functionality to Required Actions page (#56404) (…
9902eaf 
…#57207)

Co-authored-by: rich7420 <101171023+rich7420@users.noreply.github.com>
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@Lee-W Lee-W mentioned this pull request Oct 27, 2025
Closed
2 tasks
@rich7420
Copy link
Contributor Author

rich7420 commented Oct 27, 2025

Thanks for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@rich7420 @pierrejeambrun @bbovenzi @jscheffl @kaxil