Skip to content

Conversation

@RoyLee1224
Copy link
Contributor

@RoyLee1224 RoyLee1224 commented Oct 17, 2025

Related issue

part of #56738

Changes

  • Handle None values to fix auth parameter type
  • Update timezone import from airflow.utils to lazy_compat for Airflow 3.1+ compatibility

Test

CleanShot 2025-10-17 at 14 55 04

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@RoyLee1224 RoyLee1224 force-pushed the fix/providers-neo4j-mypy branch 2 times, most recently from ec63c37 to 02579f1 Compare October 18, 2025 14:50
@RoyLee1224 RoyLee1224 force-pushed the fix/providers-neo4j-mypy branch from 6405dbe to 5fab1b5 Compare October 18, 2025 18:19
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@potiuk potiuk merged commit fa18344 into apache:main Oct 20, 2025
76 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Oct 20, 2025
…he#56785)

* fix: Fix mypy type errors in Neo4j provider for SQLAlchemy 2 upgrade

* fix: Add backward-compatible import for timezone

* fix: Replace direct timezone import with lazy_compat in Neo4j provider
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
…he#56785)

* fix: Fix mypy type errors in Neo4j provider for SQLAlchemy 2 upgrade

* fix: Add backward-compatible import for timezone

* fix: Replace direct timezone import with lazy_compat in Neo4j provider
@RoyLee1224 RoyLee1224 deleted the fix/providers-neo4j-mypy branch November 4, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants