Skip to content

Fix mypy type errors in Neo4j provider for SQLAlchemy 2 upgrade #56785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Oct 20, 2025
Merged

Fix mypy type errors in Neo4j provider for SQLAlchemy 2 upgrade #56785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45aca9a
fix: Fix mypy type errors in Neo4j provider for SQLAlchemy 2 upgrade
RoyLee1224 Oct 17, 2025
5fab1b5
fix: Add backward-compatible import for timezone
RoyLee1224 Oct 18, 2025
b277f91
fix: Replace direct timezone import with lazy_compat in Neo4j provider
RoyLee1224 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion providers/neo4j/src/airflow/providers/neo4j/hooks/neo4j.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ def _create_driver(self, conn: Connection, encrypted: bool, uri: str) -> Driver:
kwargs: dict[str, Any] = {}
if parsed_uri.scheme in ["bolt", "neo4j"]:
kwargs["encrypted"] = encrypted
return GraphDatabase.driver(uri, auth=(conn.login, conn.password), **kwargs)
auth = None
if conn.login is not None and conn.password is not None:
auth = (conn.login, conn.password)
return GraphDatabase.driver(uri, auth=auth, **kwargs)

def get_uri(self, conn: Connection) -> str:
"""
Expand Down
2 changes: 1 addition & 1 deletion providers/neo4j/tests/unit/neo4j/operators/test_neo4j.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

from unittest import mock

from airflow.providers.common.compat.lazy_compat import timezone
from airflow.providers.neo4j.operators.neo4j import Neo4jOperator
from airflow.utils import timezone

DEFAULT_DATE = timezone.datetime(2015, 1, 1)
DEFAULT_DATE_ISO = DEFAULT_DATE.isoformat()
Expand Down