-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add retry for e2e test_remote_logging_s3 #56811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 3 commits into
apache:main
from
jason810496:fix/e2e/add-retry-for-test_remote_logging_s3
Oct 18, 2025
Merged
Add retry for e2e test_remote_logging_s3 #56811
potiuk
merged 3 commits into
apache:main
from
jason810496:fix/e2e/add-retry-for-test_remote_logging_s3
Oct 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py
Show resolved
Hide resolved
gopidesupavan
approved these changes
Oct 18, 2025
amoghrajesh
approved these changes
Oct 18, 2025
airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py
Outdated
Show resolved
Hide resolved
airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Oct 18, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add retry for test_remote_logging_s3 e2e test * Print list of contents found * Rename retry_delay_seconds as retry_interval_in_seconds
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Oct 20, 2025
* Add retry for test_remote_logging_s3 e2e test * Print list of contents found * Rename retry_delay_seconds as retry_interval_in_seconds
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* Add retry for test_remote_logging_s3 e2e test * Print list of contents found * Rename retry_delay_seconds as retry_interval_in_seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #56191
The
test_remote_logginge2e test is flaky because some of the logs are not yet uploaded to S3 before we validating log file names.Example fail run: https://github.com/apache/airflow/actions/runs/18613327530/job/53075269841?pr=55962
What
Add a retry mechanism to verify that a minimum number of TaskInstance logs are present in S3 before proceeding with validation.