Skip to content

Add retry for e2e test_remote_logging_s3 #56811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Oct 18, 2025
Merged

Add retry for e2e test_remote_logging_s3 #56811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7c3d37
Add retry for test_remote_logging_s3 e2e test
jason810496 Oct 18, 2025
f248bc3
Print list of contents found
jason810496 Oct 18, 2025
b52c2c7
Rename retry_delay_seconds as retry_interval_in_seconds
jason810496 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# under the License.
from __future__ import annotations

import time
from datetime import datetime, timezone

import boto3
Expand All @@ -27,6 +28,9 @@
class TestRemoteLogging:
airflow_client = AirflowClient()
dag_id = "example_xcom_test"
task_count = 6
retry_interval_in_seconds = 1
max_retries = 5

def test_dag_unpause(self):
self.airflow_client.un_pause_dag(
Expand Down Expand Up @@ -72,9 +76,25 @@ def test_remote_logging_s3(self):
bucket_name = "test-airflow-logs"
response = s3_client.list_objects_v2(Bucket=bucket_name)

# Wait for logs to be available in S3
for _ in range(self.max_retries):
response = s3_client.list_objects_v2(Bucket=bucket_name)
contents = response.get("Contents", [])
if len(contents) >= self.task_count:
break

print(f"Expected at least {self.task_count} log files, found {len(contents)}. Retrying...")
time.sleep(self.retry_interval_in_seconds)

if "Contents" not in response:
pytest.fail("No objects found in S3 bucket %s", bucket_name)

if len(response["Contents"]) < self.task_count:
pytest.fail(
f"Expected at least {self.task_count} log files in S3 bucket {bucket_name}, "
f"but found {len(response['Contents'])} objects: {[obj.get('Key') for obj in response.get('Contents', [])]}"
)

# s3 key format: dag_id=example_xcom/run_id=manual__2025-09-29T23:32:09.457215+00:00/task_id=bash_pull/attempt=1.log

log_files = [f"s3://{bucket_name}/{obj['Key']}" for obj in response["Contents"]]
Expand Down