Move triggerer from pod-log-reader-role to pod-launcher-role #56872
+142
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
jscheffl
approved these changes
Oct 20, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Totally makes sense to me that the Triggerer receives more permissions... looking forward for the other PR making Triggerer better.
Contributor
|
Oh helm tests fail... I assume you can fix this? Else let me/us know. @jedcunningham how do we handle this (did we have such in the past?) if a feature in K8s provider package has a dependency to Helm deployment? Any special care in release notes needed? @AutomationDev85 considering people might have not upgraded the Helm and would use the async mode in future, can an explicit error being generated pointing to the root cause other than a plain HTTP 403 from K8s API? |
Contributor
Author
Lzzz666
pushed a commit
to Lzzz666/airflow
that referenced
this pull request
Oct 30, 2025
…56872) * Enable triggerer with pod-launcher-role * Improve unit tests --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Open
2 tasks
danielhoherd
pushed a commit
to astronomer/apc-airflow
that referenced
this pull request
Jan 16, 2026
…56872) * Enable triggerer with pod-launcher-role * Improve unit tests --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We are preparing an update to the KubernetesPodTriggerer workflow to align its startup behavior with that of the synchronous workflow. As part of this effort, we are introducing this preparation PR.
This PR moves the triggerer to the pod-launcher-role, enabling it to read events from pods during the startup phase. Another reason for this change is to grant the triggerer the rights to clean up pods if it detects that the state of an Airflow task was set to failed by the user. This cleanup behavior will be introduced in a future PR.
We welcome your feedback on this change!
Details of change: