Unify Pod Startup Tracking: KubernetesPodTriggerer and KubernetesPodOperator Now Share Common Startup Logic #56875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
AutomationDev85
force-pushed
the
feature/KubernetesPodOperator-async-and-sync-use-the-same-start-code
branch
from
2df75db to
18c1f6a
Compare
jscheffl
reviewed
Oct 20, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I see where this is heading to - and thanks for the consolidation. Seems to be a bit of effort. Hope you are not scared by the amount of comments but a bit of rework is needed.
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_pod.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_pod_manager.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Outdated
Show resolved
Hide resolved
AutomationDev85
force-pushed
the
feature/KubernetesPodOperator-async-and-sync-use-the-same-start-code
branch
from
18c1f6a to
18faa47
Compare
jscheffl
reviewed
Oct 26, 2025
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_pod.py
Show resolved
Hide resolved
added 2 commits
October 28, 2025 08:33
jscheffl
approved these changes
Oct 28, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the cleanup and improvement. Looks good now. I'll leave the PR open for some other eyes to review, otherwise will merge the next day or so.
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…perator Now Share Common Startup Logic (apache#56875) * Move container-related functions from PodManager to a separate file * Moved unit tests * Sync and async workflow use the same code to track Pod startup * Reworked unit tests and pod startup logic * Add api permission error detection for triggerer * Fix pytest fixture * Removed not requried code --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aligns the startup behavior of KubernetesPodTriggerer and KubernetesPodOperator, ensuring both the synchronous and asynchronous workflows use the same code to track pod startup.
It incorporates changes from the preparation PR #56700, making this PR easier to review once merged. Additionally, PR #56872 is a prerequisite, as it grants the triggerer the necessary permissions to access pod events.
As this is a significant update, we welcome feedback from the community!
Details of change: