Common.Compat: Extract reusable compat utilities and rename to sdk #56884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
boring-cyborg
bot
added
area:providers
provider:common-compat
provider:edge
eladkal
reviewed
Oct 20, 2025
kaxil
force-pushed
the
refactor-common-compat-sdk
branch
2 times, most recently
from
118e17b to
d2ec878
Compare
Member
|
Yep. .sdk is better than lazy_compat :) |
jscheffl
approved these changes
Oct 20, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
sdkas term is much better! Thanks!
Extract compatibility import logic into reusable _compat_utils module and rename lazy_compat to sdk for better clarity. The new architecture makes it easier to maintain consistency across all compatibility modules without introducing cycles due to which mypy was failing in apache#56867
kaxil
force-pushed
the
refactor-common-compat-sdk
branch
from
d2ec878 to
3e1c1fb
Compare
13 tasks
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract compatibility import logic into reusable _compat_utils module and rename lazy_compat to sdk for better clarity. The new architecture makes it easier to maintain consistency across all compatibility modules without introducing cycles due to which mypy was failing in #56867
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.