-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix(scheduler): load dag_run eagering for execution API validation #56916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f35b7f to
d896184
Compare
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to reproduce the error & does this fix it. (It should but worth verifying)
yep, I'm now simplifying the sample code I used and will add to the desciprion |
|
Updated the Dag and steps I used in detail |
…alidation (apache#56916) (cherry picked from commit 8ffb7b1) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
…ation (apache#56916)" This reverts commit 8ffb7b1.
|
Hey @Lee-W -> we had to revert it as it fails for Python 3.13. Can you please re-do it (and set See https://github.com/apache/airflow/actions/runs/18676364216/job/53249204014 |
…ation (apache#56916)" (apache#56943) This reverts commit 8ffb7b1.
…on API validation (apache#56916)" (apache#56943) This reverts commit 8ffb7b1. (cherry picked from commit 209fb2e) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…dation (apache#56916)" (apache#56943) This reverts commit 209fb2e.
…alidation (apache#57010) (apache#57045) Co-authored-by: Wei Lee <weilee.rx@gmail.com> fix(scheduler): load dag_run eagering for execution API validation (apache#56916)" (apache#56943)
…57062) * [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031) Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> * [v3-1-test] Fix Extra Links translation key. (#57030) (#57040) (cherry picked from commit 8d71c07) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> * [v3-1-test] Fix dags list not rendering (#57037) (#57046) (cherry picked from commit 8668fe5) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045) Co-authored-by: Wei Lee <weilee.rx@gmail.com> fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943) * [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047) Fix dag list cache invalidation on favouriting a dag (cherry picked from commit 4e46212) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] Add new PL translations. (#56359) (#57055) (cherry picked from commit 6583b6d) * Add last missing translation for 3.1.1 (#57057) * [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048) * [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) * fix: adjust PanelButtons spacing and alignment * Fix PanelButtons layout and button styling * Fix PanelButtons: use bg.subtle and remove unnecessary _hover (cherry picked from commit 4c35cd2) Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
…57062) * [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031) Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> * [v3-1-test] Fix Extra Links translation key. (#57030) (#57040) (cherry picked from commit 8d71c07) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> * [v3-1-test] Fix dags list not rendering (#57037) (#57046) (cherry picked from commit 8668fe5) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045) Co-authored-by: Wei Lee <weilee.rx@gmail.com> fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943) * [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047) Fix dag list cache invalidation on favouriting a dag (cherry picked from commit 4e46212) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] Add new PL translations. (#56359) (#57055) (cherry picked from commit 6583b6d) * Add last missing translation for 3.1.1 (#57057) * [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048) * [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) * fix: adjust PanelButtons spacing and alignment * Fix PanelButtons layout and button styling * Fix PanelButtons: use bg.subtle and remove unnecessary _hover (cherry picked from commit 4c35cd2) Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
… en (#57060) (#57064) * [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031) Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> * [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) (#57062) * [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031) Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> * [v3-1-test] Fix Extra Links translation key. (#57030) (#57040) (cherry picked from commit 8d71c07) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> * [v3-1-test] Fix dags list not rendering (#57037) (#57046) (cherry picked from commit 8668fe5) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045) Co-authored-by: Wei Lee <weilee.rx@gmail.com> fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943) * [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047) Fix dag list cache invalidation on favouriting a dag (cherry picked from commit 4e46212) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * [v3-1-test] Add new PL translations. (#56359) (#57055) (cherry picked from commit 6583b6d) * Add last missing translation for 3.1.1 (#57057) * [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048) * [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) * fix: adjust PanelButtons spacing and alignment * Fix PanelButtons layout and button styling * Fix PanelButtons: use bg.subtle and remove unnecessary _hover (cherry picked from commit 4c35cd2) Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com> * [v3-1-test] Add possibility of removing extra translations missing in en (#57060) Sometimes we rename/move translation - we did not have a tool to remove such dangling translations. Now we have. (cherry picked from commit 2314099) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com> Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
Why
Closes: #56763
how to reproduce (through breeze on e24cfb0)
files/airflow-breeze-config/environment_variables.envfiles/dagsDag
breeze start-airflow --db-reset --backend postgresproduerandconumserDagsproducer(10 ~ 20 times) really quickWhat
Kaxil implemented a
_eager_load_dag_run_for_validationmethod to ensure that dag_run exists even when a ti becomes a zombie task^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.