Skip to content

fix(scheduler): load dag_run eagering for execution API validation #57010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Oct 22, 2025
Merged

fix(scheduler): load dag_run eagering for execution API validation #57010

potiuk merged 2 commits into from
Oct 22, 2025

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 22, 2025 •
edited
Loading

Why

Reapply #56916 with fix

What

joinedload TI.dag_run instead of selectinload

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W Lee-W requested review from XD-DENG and ashb as code owners October 22, 2025 01:44
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Oct 22, 2025
@Lee-W Lee-W added all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Oct 22, 2025
@kaxil kaxil added this to the Airflow 3.1.2 milestone Oct 22, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Oct 22, 2025

@kaxil, would it be possible to include it in 3.1.1 instead? Without it, the original fix mightt cause some issues in Python 3.13

@kaxil
Copy link
Member

kaxil commented Oct 22, 2025

@kaxil, would it be possible to include it in 3.1.1 instead? Without it, the original fix mightt cause some issues in Python 3.13

Haven't included original fix in v3-1-test I think -- but yeah might be able to in my morning

@Lee-W
Copy link
Member Author

Lee-W commented Oct 22, 2025

I think the original fix has already been backported but not reverted

@potiuk
Copy link
Member

potiuk commented Oct 22, 2025

I think the original fix has already been backported but not reverted

I reverted it yesterday.

@potiuk potiuk modified the milestones: Airflow 3.1.2, Airflow 3.1.1 Oct 22, 2025
@potiuk potiuk merged commit 833717a into apache:main Oct 22, 2025
63 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 22, 2025
@Lee-W
[v3-1-test] fix(scheduler): load dag_run eagering for execution API v…
208073c 
…alidation (#57010)

* Reapply "fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943)

This reverts commit 209fb2e.

* fix(scheduler): joinedload TI.dag_run instead of selectinload
(cherry picked from commit 833717a)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

Lee-W added a commit that referenced this pull request Oct 22, 2025
@github-actions @Lee-W
[v3-1-test] fix(scheduler): load dag_run eagering for execution API v…
27e6e19 
…alidation (#57010) (#57045)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Oct 22, 2025
@github-actions @Lee-W @kaxil
[v3-1-test] fix(scheduler): load dag_run eagering for execution API v…
2c26772 
…alidation (apache#57010) (apache#57045)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fix(scheduler): load dag_run eagering for execution API validation (apache#56916)" (apache#56943)
pierrejeambrun added a commit that referenced this pull request Oct 22, 2025
@github-actions @sjyangkevin
@tirkarthi @pierrejeambrun @Lee-W @potiuk @anshuksi282-ksolves
[v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) (#…
2218482 
…57062)

* [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>

* [v3-1-test] Fix Extra Links translation key. (#57030) (#57040)

(cherry picked from commit 8d71c07)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

* [v3-1-test] Fix dags list not rendering (#57037) (#57046)

(cherry picked from commit 8668fe5)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943)

* [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047)

Fix dag list cache invalidation on favouriting a dag
(cherry picked from commit 4e46212)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] Add new PL translations. (#56359) (#57055)

(cherry picked from commit 6583b6d)

* Add last missing translation for 3.1.1 (#57057)

* [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048)

* [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570)

* fix: adjust PanelButtons spacing and alignment

* Fix PanelButtons layout and button styling

* Fix PanelButtons: use bg.subtle and remove unnecessary _hover
(cherry picked from commit 4c35cd2)

Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
kaxil pushed a commit that referenced this pull request Oct 23, 2025
@github-actions @sjyangkevin
@tirkarthi @pierrejeambrun @Lee-W @potiuk @anshuksi282-ksolves @kaxil
[v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) (#…
ead0603 
…57062)

* [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>

* [v3-1-test] Fix Extra Links translation key. (#57030) (#57040)

(cherry picked from commit 8d71c07)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

* [v3-1-test] Fix dags list not rendering (#57037) (#57046)

(cherry picked from commit 8668fe5)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943)

* [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047)

Fix dag list cache invalidation on favouriting a dag
(cherry picked from commit 4e46212)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] Add new PL translations. (#56359) (#57055)

(cherry picked from commit 6583b6d)

* Add last missing translation for 3.1.1 (#57057)

* [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048)

* [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570)

* fix: adjust PanelButtons spacing and alignment

* Fix PanelButtons layout and button styling

* Fix PanelButtons: use bg.subtle and remove unnecessary _hover
(cherry picked from commit 4c35cd2)

Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
potiuk added a commit that referenced this pull request Oct 25, 2025
@github-actions @sjyangkevin
@tirkarthi @pierrejeambrun @Lee-W @potiuk @anshuksi282-ksolves
[v3-1-test] Add possibility of removing extra translations missing in…
0a65c9c 
… en (#57060) (#57064)

* [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>

* [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570) (#57062)

* [v3-1-test] Fix Outlet Event Extra Data is Empty in Task Instance Success Listener (#54568) (#57031)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>

* [v3-1-test] Fix Extra Links translation key. (#57030) (#57040)

(cherry picked from commit 8d71c07)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

* [v3-1-test] Fix dags list not rendering (#57037) (#57046)

(cherry picked from commit 8668fe5)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] fix(scheduler): load dag_run eagering for execution API validation (#57010) (#57045)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fix(scheduler): load dag_run eagering for execution API validation (#56916)" (#56943)

* [v3-1-test] Fix dag list cache invalidation on favouriting a dag (#57039) (#57047)

Fix dag list cache invalidation on favouriting a dag
(cherry picked from commit 4e46212)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* [v3-1-test] Add new PL translations. (#56359) (#57055)

(cherry picked from commit 6583b6d)

* Add last missing translation for 3.1.1 (#57057)

* [v3-1-test] Close German translation gaps for full UI translation 2025-10-21 (#56980) (#57048)

* [v3-1-test] Fix: Adjust PanelButtons spacing and alignment (#56570)

* fix: adjust PanelButtons spacing and alignment

* Fix PanelButtons layout and button styling

* Fix PanelButtons: use bg.subtle and remove unnecessary _hover
(cherry picked from commit 4c35cd2)

Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>

* [v3-1-test] Add possibility of removing extra translations missing in en (#57060)

Sometimes we rename/move translation - we did not have a tool to
remove such dangling translations. Now we have.
(cherry picked from commit 2314099)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: anshuksi282-ksolves <anshu.singh@ksolves.com>
@potiuk potiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

+1 more reviewer

@sunank200 sunank200 sunank200 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:Scheduler including HA (high availability) scheduler backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Lee-W @kaxil @potiuk @sunank200