Reimplement Sentry integration in Task SDK #57032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
sentry-in-sdk
branch
12 times, most recently
from
6a7a4f6 to
9d04993
Compare
uranusjr
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
uranusjr
force-pushed
the
sentry-in-sdk
branch
2 times, most recently
from
019ae56 to
9f40e52
Compare
jason810496
reviewed
Oct 30, 2025
Lee-W
approved these changes
Nov 4, 2025
The integration logic is moved from core into task sdk so it can be run at runtime. Things that used to rely on database access have been rewritten to use the execution API instead. Not yet applied to anything. Tests to come.
This is needed to reflect core dep changes since we've removed Sentry (and its Flask integration) from core.
Sentry tends to mess with logging (seems to be related to the debug helpers it runs AT IMPORT TIME), which in turn messes up out supervisor tests. The Sentry integration tests are now rewritten to not actually use the Sentry SDK at all to avoid this issue. The problem now is I have no real way to actually know if the integration actually works anymore. We'll need to figure that out in another way.
The Sentry integration need to not import other parts at top-level.
uranusjr
force-pushed
the
sentry-in-sdk
branch
from
9f40e52 to
9282cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52368.