Skip to content

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Nov 4, 2025

Follow-up to #57032.

An executor should declare the integration it wants to support. That declaration (an import path) is sent to a task when the executor runs it as a part of the workload. The SDK loads that string to RuntimeTaskInstance, and the Sentry integration code uses it to import the relevant callable to run.

Since the integration information is only known when the executor passes it to the task runner, I changed the Sentry integration to be initialised lazily when enrich_error is called (instead of __init__ i.e. initialised when the task runner process starts).

@boring-cyborg boring-cyborg bot added area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler area:task-sdk kind:documentation provider:celery provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Nov 4, 2025
@jason810496 jason810496 self-requested a review November 4, 2025 14:48
@uranusjr uranusjr force-pushed the sentry-in-sdk-celery-support branch from bc076aa to b4ce178 Compare November 5, 2025 03:04
@uranusjr uranusjr requested a review from jscheffl as a code owner November 5, 2025 03:04
@uranusjr uranusjr force-pushed the sentry-in-sdk-celery-support branch 11 times, most recently from 47612d8 to 6976e7e Compare November 6, 2025 06:45
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uranusjr uranusjr force-pushed the sentry-in-sdk-celery-support branch from 6976e7e to 82bbb6a Compare November 24, 2025 07:36
@uranusjr uranusjr merged commit 6c0032f into apache:main Nov 24, 2025
119 checks passed
@uranusjr uranusjr deleted the sentry-in-sdk-celery-support branch November 24, 2025 08:38
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler area:task-sdk kind:documentation provider:celery provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants