Skip to content

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Oct 23, 2025

earlier, whenever i was running uv sync, i noticed the warning:

warning: The package `pandas==2.1.4` does not have an extra named `postgres`
image

I checked pandas repo's pyproject.toml and see that its postgresql, not postgres - https://github.com/pandas-dev/pandas/blob/81f8d5d3199d0ec3f94ad7eb8015e183b1681275/pyproject.toml#L73

@eladkal
Copy link
Contributor

eladkal commented Oct 23, 2025

Can you please amend the commit messages?
We generate release notes from the commit. It's better to provide some context so users who read it will understand what the fix is about

The Presto provider was specifying 'pandas[postgres]' as a dependency,
but pandas does not have a 'postgres' extra. The correct extra name is
'postgresql', which includes SQLAlchemy, psycopg2, and adbc-driver-postgresql
for PostgreSQL database support.

This fixes the warning: 'The package pandas==2.1.4 does not have an extra named postgres'
that appeared during 'uv sync' operations.
@rawwar rawwar force-pushed the kalyan/providers/presto/fix_pandas_extra branch from 877c449 to 278ccb7 Compare October 23, 2025 09:27
@rawwar
Copy link
Contributor Author

rawwar commented Oct 23, 2025

Can you please amend the commit messages? We generate release notes from the commit. It's better to provide some context so users who read it will understand what the fix is about

updated it

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@eladkal eladkal merged commit eae91fb into apache:main Oct 27, 2025
91 checks passed
@rawwar rawwar deleted the kalyan/providers/presto/fix_pandas_extra branch October 27, 2025 08:01
@potiuk
Copy link
Member

potiuk commented Oct 27, 2025

Nice!

@ashb
Copy link
Member

ashb commented Nov 4, 2025

uv run -p 3.12 python -m pytest airflow-core/tests/unit/jobs/test_scheduler_job.py
Using CPython 3.12.7
Removed virtual environment at: .venv
Creating virtual environment at: .venv
  × Failed to build `psycopg2==2.9.11`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta:__legacy__.build_wheel` failed (exit status: 1)

      [stdout]
      running egg_info
      writing psycopg2.egg-info/PKG-INFO
      writing dependency_links to psycopg2.egg-info/dependency_links.txt
      writing top-level names to psycopg2.egg-info/top_level.txt

      [stderr]
      /Users/ash/.cache/uv/builds-v0/.tmpkOwkPL/lib/python3.12/site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
      !!

              ********************************************************************************
              Please consider removing the following classifiers in favor of a SPDX license expression:

              License :: OSI Approved :: GNU Library or Lesser General Public License (LGPL)

              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
              ********************************************************************************
      !!
        self._finalize_license_expression()

      Error: pg_config executable not found.

I propose we remove that postgres extra.

ashb added a commit that referenced this pull request Nov 4, 2025
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141
ashb added a commit that referenced this pull request Nov 4, 2025
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141
ashb added a commit that referenced this pull request Nov 4, 2025
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141
potiuk pushed a commit that referenced this pull request Nov 4, 2025
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141
ashb added a commit that referenced this pull request Nov 4, 2025
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141
ashb added a commit that referenced this pull request Nov 5, 2025
…ct psycopg2-binary. (#57813)

This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in #57141 (before then it issued a
warning about an unknown extra)

But some things have an implicit dep on Psycopg2 being available, so we
depend directly on the (correct for us) psycopg2-binary.
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…ct psycopg2-binary. (apache#57813)

This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.

Since this wasn't behind an extra, and not every user needs it, _and_ since it
conflicts with our own postgres deps, I think removal is the best option.

This was only recently added/made working in apache#57141 (before then it issued a
warning about an unknown extra)

But some things have an implicit dep on Psycopg2 being available, so we
depend directly on the (correct for us) psycopg2-binary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants