-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix postgresql extra #57141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix postgresql extra #57141
Conversation
|
Can you please amend the commit messages? |
The Presto provider was specifying 'pandas[postgres]' as a dependency, but pandas does not have a 'postgres' extra. The correct extra name is 'postgresql', which includes SQLAlchemy, psycopg2, and adbc-driver-postgresql for PostgreSQL database support. This fixes the warning: 'The package pandas==2.1.4 does not have an extra named postgres' that appeared during 'uv sync' operations.
877c449 to
278ccb7
Compare
updated it |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
|
Nice! |
I propose we remove that postgres extra. |
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
…ct psycopg2-binary. (#57813) This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141 (before then it issued a warning about an unknown extra) But some things have an implicit dep on Psycopg2 being available, so we depend directly on the (correct for us) psycopg2-binary.
…ct psycopg2-binary. (apache#57813) This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in apache#57141 (before then it issued a warning about an unknown extra) But some things have an implicit dep on Psycopg2 being available, so we depend directly on the (correct for us) psycopg2-binary.
earlier, whenever i was running
uv sync, i noticed the warning:I checked pandas repo's pyproject.toml and see that its
postgresql, notpostgres- https://github.com/pandas-dev/pandas/blob/81f8d5d3199d0ec3f94ad7eb8015e183b1681275/pyproject.toml#L73