feat: backwards comp get async conn #57143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramitkataria
approved these changes
Oct 23, 2025
Contributor
ramitkataria
left a comment
ramitkataria
left a comment
There was a problem hiding this comment.
Just a nit but otherwise looks good to me
providers/common/compat/tests/unit/common/compat/connection/test_connection.py
Show resolved
Hide resolved
KoviAnusha
reviewed
Oct 24, 2025
providers/common/compat/tests/unit/common/compat/connection/test_connection.py
Show resolved
Hide resolved
providers/common/compat/src/airflow/providers/common/compat/connection/__init__.py
Show resolved
Hide resolved
dondaum
force-pushed
the
feat/move-back-async-get-con-to-common-prov
branch
from
65407eb to
3dd0067
Compare
Contributor
ramitkataria
approved these changes
Oct 30, 2025
providers/common/compat/tests/unit/common/compat/connection/test_connection.py
Show resolved
Hide resolved
Lee-W
approved these changes
Nov 3, 2025
This was referenced Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have a backwards compatible way to get an Airflow connection asynchronously. Otherwise, each provider package must implement similar functionality to use the new
BaseHook.aget_connection(...)method.I haven't found a suitable place to add this feature. I am happy about every recommendation here.
related: #56791
cc @ramitkataria
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.