-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat: backwards comp get async conn #57143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ferruzzi
merged 1 commit into
apache:main
from
dondaum:feat/move-back-async-get-con-to-common-prov
Nov 4, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
providers/common/compat/src/airflow/providers/common/compat/connection/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from airflow.providers.common.compat.sdk import BaseHook | ||
|
|
||
| if TYPE_CHECKING: | ||
| from airflow.providers.common.compat.sdk import Connection | ||
|
|
||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| async def get_async_connection(conn_id: str) -> Connection: | ||
| """ | ||
| Get an asynchronous Airflow connection that is backwards compatible. | ||
|
|
||
| :param conn_id: The provided connection ID. | ||
| :returns: Connection | ||
| """ | ||
| from asgiref.sync import sync_to_async | ||
|
|
||
| if hasattr(BaseHook, "aget_connection"): | ||
| log.debug("Get connection using `BaseHook.aget_connection().") | ||
| return await BaseHook.aget_connection(conn_id=conn_id) | ||
| log.debug("Get connection using `BaseHook.get_connection().") | ||
| return await sync_to_async(BaseHook.get_connection)(conn_id=conn_id) | ||
|
|
||
|
|
||
| __all__ = [ | ||
| "get_async_connection", | ||
| ] |
16 changes: 16 additions & 0 deletions
16
providers/common/compat/tests/unit/common/compat/connection/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. |
69 changes: 69 additions & 0 deletions
69
providers/common/compat/tests/unit/common/compat/connection/test_connection.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from unittest import mock | ||
|
|
||
| import pytest | ||
|
|
||
| from airflow.models.connection import Connection | ||
| from airflow.providers.common.compat.connection import get_async_connection | ||
|
|
||
|
|
||
| class MockAgetBaseHook: | ||
| def __init__(*args, **kargs): | ||
| pass | ||
|
|
||
| async def aget_connection(self, conn_id: str): | ||
| return Connection( | ||
| conn_id="test_conn", | ||
| conn_type="http", | ||
| password="secret_token_aget", | ||
| ) | ||
|
|
||
|
|
||
| class MockBaseHook: | ||
| def __init__(*args, **kargs): | ||
| pass | ||
|
|
||
| def get_connection(self, conn_id: str): | ||
| return Connection( | ||
| conn_id="test_conn_sync", | ||
| conn_type="http", | ||
| password="secret_token", | ||
| ) | ||
|
|
||
|
|
||
| class TestGetAsyncConnection: | ||
| @mock.patch("airflow.providers.common.compat.connection.BaseHook", new_callable=MockAgetBaseHook) | ||
| @pytest.mark.asyncio | ||
| async def test_get_async_connection_with_aget(self, _, caplog): | ||
| with caplog.at_level(logging.DEBUG): | ||
| conn = await get_async_connection("test_conn") | ||
| assert conn.password == "secret_token_aget" | ||
ferruzzi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| assert conn.conn_type == "http" | ||
| assert "Get connection using `BaseHook.aget_connection()." in caplog.text | ||
|
|
||
| @mock.patch("airflow.providers.common.compat.connection.BaseHook", new_callable=MockBaseHook) | ||
| @pytest.mark.asyncio | ||
| async def test_get_async_connection_with_get_connection(self, _, caplog): | ||
| with caplog.at_level(logging.DEBUG): | ||
| conn = await get_async_connection("test_conn") | ||
| assert conn.password == "secret_token" | ||
| assert conn.conn_type == "http" | ||
| assert "Get connection using `BaseHook.get_connection()." in caplog.text | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.