Skip to content

Conversation

@jscheffl
Copy link
Contributor

As prek is supporting monorepo now and go SDK was the front-runner, fab provider is now the next piece that with this PR is proposed to be split-out from global pre-commit hook list into the provider space.

@jscheffl jscheffl requested a review from vincbeck as a code owner October 23, 2025 21:53
@boring-cyborg boring-cyborg bot added area:dev-tools area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:fab labels Oct 23, 2025
@jscheffl jscheffl requested review from kaxil and potiuk October 23, 2025 21:53
@jscheffl jscheffl removed the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 23, 2025
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have verified that this works (i.e. prek hooks run) without bugs, yea?

@kaxil
Copy link
Member

kaxil commented Oct 23, 2025

You have verified that this works (i.e. prek hooks run) without bugs, yea?

I assume we don't need to do anything different in CI to run it there too?

@jscheffl
Copy link
Contributor Author

You have verified that this works (i.e. prek hooks run) without bugs, yea?

I assume we don't need to do anything different in CI to run it there too?

Also my assumption - this is why we have a CI? All static checks are executed there.

@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label Oct 23, 2025
@kaxil
Copy link
Member

kaxil commented Oct 23, 2025

I assume we don't need to do anything different in CI to run it there too?

Also my assumption - this is why we have a CI? All static checks are executed there.

As long as it runs :D

@jscheffl
Copy link
Contributor Author

I assume we don't need to do anything different in CI to run it there too?

Also my assumption - this is why we have a CI? All static checks are executed there.

As long as it runs :D

This is how it runs in https://github.com/apache/airflow/actions/runs/18763029405/job/53533026350?pr=57181:
image

@kaxil
Copy link
Member

kaxil commented Oct 23, 2025

Nice yeah that looks great

@jscheffl jscheffl force-pushed the feature/extract-pre-commit-for-fab branch from 26c08de to ef74f56 Compare October 24, 2025 05:51
@vincbeck vincbeck merged commit 267882a into apache:main Oct 24, 2025
112 checks passed
@potiuk
Copy link
Member

potiuk commented Oct 25, 2025

Yep. Nothing should be needed - prek auto-discovers all pre-commit config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers full tests needed We need to run full set of tests for this PR to merge provider:fab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants