-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Extract prek hooks for FAB provider #57181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract prek hooks for FAB provider #57181
Conversation
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have verified that this works (i.e. prek hooks run) without bugs, yea?
I assume we don't need to do anything different in CI to run it there too? |
Also my assumption - this is why we have a CI? All static checks are executed there. |
As long as it runs :D |
This is how it runs in https://github.com/apache/airflow/actions/runs/18763029405/job/53533026350?pr=57181: |
|
Nice yeah that looks great |
26c08de to
ef74f56
Compare
|
Yep. Nothing should be needed - prek auto-discovers all pre-commit config files. |

As prek is supporting monorepo now and go SDK was the front-runner, fab provider is now the next piece that with this PR is proposed to be split-out from global pre-commit hook list into the provider space.