Extract prek hooks for Providers #57250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
commented
Oct 25, 2025
jscheffl
force-pushed
the
feature/extract-pre-commit-for-providers
branch
from
c597fdd to
e2a77db
Compare
Member
|
Static checks to fix ... but I love it :) |
Member
|
BTW. There might be some code in breeze that finds providers by looking at the sub-folders of "providers" but it might also do it for files .. so maybe some breeze update is needed. |
Contributor
Author
I am on it just need to complete some other duties in parallel... stay tuned... |
Member
|
No. Looks good. Seems we are always using "rglob" and finding something ("provider.yaml" or "integration" folder). |
potiuk
approved these changes
Oct 25, 2025
gopidesupavan
approved these changes
Oct 25, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
LGTM , nice to see separation :)
jscheffl
force-pushed
the
feature/extract-pre-commit-for-providers
branch
from
e2a77db to
22ae396
Compare
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
jason810496 and
kaxil
as code owners
potiuk
added
the
backport-to-v3-1-test
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 045fbc5 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Oct 25, 2025
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Oct 25, 2025
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk
added a commit
that referenced
this pull request
Oct 25, 2025
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Member
|
Backport #57260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #57181 this is now a batch for all prek hooks that are "just" solely for providers to split out from root:
As prek is supporting monorepo now and go SDK was the front-runner, provider root is now the next piece that with this PR is proposed to be split-out from global pre-commit hook list into the provider space.