Auto-compile UI assets on Breeze start-airflow command #57219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
approved these changes
Oct 25, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Very nice! I think one small thing to add is to be able to set
--use-airflow-version=57219
Where the number is a PR#.. We could easily retrieve the repo/branch via gh api.
Member
|
But this could be "extra". |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2025
…57219) * Compile assets when installing airflow from Github Branch in Breeze * Only install pnpm * Fix main UI compliation * Generalize compile_ui_assets for simple_auth_manager ui * Remove "no assets compiled" warning * Fix test due to compile_ui_assets not found (cherry picked from commit 505d9e4) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Backport successfully created: v3-1-test
|
potiuk
pushed a commit
that referenced
this pull request
Oct 25, 2025
…57219) (#57253) * Compile assets when installing airflow from Github Branch in Breeze * Only install pnpm * Fix main UI compliation * Generalize compile_ui_assets for simple_auth_manager ui * Remove "no assets compiled" warning * Fix test due to compile_ui_assets not found (cherry picked from commit 505d9e4) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54453
related: #54070
Why
After #54070, we are able to use specific airflow-core version for
start-airflowcommand but when we access Airflow UI, it will always show internal server error. Since the UI dist will not be compiled when runningstart-airflowcommand.How
--use-airflow-versionprovided (/opt/airflow/.build/airflow.tar.gz/opt/airflow/.build/airflow_sourcedirectory/opt/airflow/airflow-core/src/airflow/ui/opt/airflow/airflow-core/src/airflow/api_fastapi/auth/managers/simple/uinodeandpnpmif not existedpnpm run buildin both UI directories/opt/airflow/airflow-core/...) to Airflow Installation Path (e.g./usr/python/lib/python3.10/site-packages/airflow/...)What
After this PR, if we run
breeze start-airflowwith any--use-airflow-version <owner/repo:branch>we could access the UI without API Server response internal error.For example: