Support PR number with use-airflow-version in Breeze #57667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Refactor: consolidate PR number and repo:branch logic in find_installation_spec Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Remove unused get_repo_and_branch_from_pr function Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jason810496
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jedcunningham,
jscheffl,
kaxil and
potiuk
as code owners
jscheffl
approved these changes
Nov 1, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Very cool! Seems to work as well as code looks good. That is a very cool feature to be faster in review!
potiuk
approved these changes
Nov 1, 2025
Member
|
Indeed. Cool as a breeze :) |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 19809dd v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Nov 1, 2025
…che#57667) * Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Refactor: consolidate PR number and repo:branch logic in find_installation_spec Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Remove unused get_repo_and_branch_from_pr function Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Remove not used github utils --------- (cherry picked from commit 19809dd) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
potiuk
added a commit
that referenced
this pull request
Nov 1, 2025
) (#57688) * Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories Refactor: consolidate PR number and repo:branch logic in find_installation_spec Remove unused get_repo_and_branch_from_pr function Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories * Remove not used github utils --------- (cherry picked from commit 19809dd) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Member
|
Backport in #57688 |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 3, 2025
) (#57688) * Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories Refactor: consolidate PR number and repo:branch logic in find_installation_spec Remove unused get_repo_and_branch_from_pr function Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories * Remove not used github utils --------- (cherry picked from commit 19809dd) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 4, 2025
) (#57688) * Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories Refactor: consolidate PR number and repo:branch logic in find_installation_spec Remove unused get_repo_and_branch_from_pr function Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Add tests for PR number pattern matching Move PR_NUMBER_PATTERN to global_constants for consistency Add error handling for deleted fork repositories * Remove not used github utils --------- (cherry picked from commit 19809dd) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copilot AI
added a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Refactor: consolidate PR number and repo:branch logic in find_installation_spec Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Remove unused get_repo_and_branch_from_pr function Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Remove not used github utils --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #57219
Why
Follow-up PR of Auto-compile UI assets on Breeze start-airflow command #57219 to support
--use-airflow-versionwith<pr_num>.What
Add a util to parse
<pr_number>toowner/repo:branchformat via GitHub API and we are able tostart-airflowwith specific<pr_numberlike: