Only show latest minor versions in version drop-down in docs #57243
Conversation
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
kaxil
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
force-pushed
the
filter-versions-to-latest-minor
branch
from
7972c7a to
09c654d
Compare
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I think this is a good solution! I like it.
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Yes indeed, definitely worth limiting :) LGTM
|
Let's wait for others / devlist comments -> this is quite a change. It might be a little confusing for users (I imagine) - and I am not entirely sure if 10 last versions is good cut-off ? |
I think when all the non-latest minor are off then we can get back to the full list in my view... At least every 6 months I have a reason to check for 1.10 docs :-D Maybe a "all other versions..." can be added in the dropdown leading to a version browser page that lists all in a scrollable page? |
That's "advanced" UI work - that no-one pivcked up yet :) |
potiuk
force-pushed
the
filter-versions-to-latest-minor
branch
from
09c654d to
e045634
Compare
This does not remove the actual versions from S3 only limits the drop-down. All versions are available still to see and they are indexed, also links from PyPI continue to work, you can also manually update version in the URL.
potiuk
force-pushed
the
filter-versions-to-latest-minor
branch
from
e045634 to
a64ed77
Compare
|
The setup for 20 versions seems like really good for now :) |
…ocs (#57243) This does not remove the actual versions from S3 only limits the drop-down. All versions are available still to see and they are indexed, also links from PyPI continue to work, you can also manually update version in the URL. (cherry picked from commit a0b4d29) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-1-test
|
…ocs (#57243) (#57262) This does not remove the actual versions from S3 only limits the drop-down. All versions are available still to see and they are indexed, also links from PyPI continue to work, you can also manually update version in the URL. (cherry picked from commit a0b4d29) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Cool! |
3 participants
This does not remove the actual versions from S3 only limits the drop-down. All versions are available still to see and they are indexed, also links from PyPI continue to work, you can also manually update version in the URL.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.