Fix memory leak in Client via SSL context creation #57334
Merged
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@wjddn279 I am working on a fix for the failing tests, do not worry about that one :) |
Contributor
|
Fix here: #57335 |
amoghrajesh
approved these changes
Oct 27, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks for the investigation @wjddn279!
A new client is created per task execution, that number could be high in a busy environment. Looks like a nice improvement.
kaxil
reviewed
Oct 27, 2025
kaxil
reviewed
Oct 27, 2025
kaxil
reviewed
Oct 27, 2025
kaxil
reviewed
Oct 27, 2025
wjddn279
force-pushed
the
fix-ssl-context-memory-leak
branch
from
c417b1d to
7ca1a48
Compare
Contributor
Author
|
@kaxil @amoghrajesh Thanks for checking! 👍 |
kaxil
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
related: #56641 When I performed the same memray inspection on the latest version that includes both fixes, the first issue was clearly resolved, but the second issue still persists. [memray1.html](https://github.com/user-attachments/files/23160226/memray1.html) When a Client object is created, `ctx = ssl.create_default_context(cafile=ca_file)` continues to be executed repeatedly, which accumulates in memory and causes a memory leak. (It appears to be allocated as a C language object and remains in memory regardless of Python object GC) This PR uses caching to prevent the SSL context object from being recreated. Here are the results after running for two hours with this change. The memory usage, which was previously growing to tens of MBs, now stabilizes at approximately 700KB. [memray2.html](https://github.com/user-attachments/files/23160405/memray2.html) (cherry picked from commit 7369e46) Co-authored-by: Jeongwoo Do <48639483+wjddn279@users.noreply.github.com>
Backport successfully created: v3-1-test
|
potiuk
pushed a commit
that referenced
this pull request
Oct 27, 2025
… (#57374) related: #56641 When I performed the same memray inspection on the latest version that includes both fixes, the first issue was clearly resolved, but the second issue still persists. [memray1.html](https://github.com/user-attachments/files/23160226/memray1.html) When a Client object is created, `ctx = ssl.create_default_context(cafile=ca_file)` continues to be executed repeatedly, which accumulates in memory and causes a memory leak. (It appears to be allocated as a C language object and remains in memory regardless of Python object GC) This PR uses caching to prevent the SSL context object from being recreated. Here are the results after running for two hours with this change. The memory usage, which was previously growing to tens of MBs, now stabilizes at approximately 700KB. [memray2.html](https://github.com/user-attachments/files/23160405/memray2.html) (cherry picked from commit 7369e46) Co-authored-by: Jeongwoo Do <48639483+wjddn279@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #56641
@kaxil has addressed the second item in this issue. When I performed the same memray inspection on the latest version that includes both fixes, the first issue was clearly resolved, but the second issue still persists.
memray1.html
When a Client object is created,
ctx = ssl.create_default_context(cafile=ca_file)continues to be executed repeatedly, which accumulates in memory and causes a memory leak. (It appears to be allocated as a C language object and remains in memory regardless of Python object GC)This PR uses caching to prevent the SSL context object from being recreated.
Here are the results after running for two hours with this change. The memory usage, which was previously growing to tens of MBs, now stabilizes at approximately 700KB.
memray2.html
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.