-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Move structlog imports into a TYPE_CHECKING block to untie version bumps #57335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets see if TP's idea works
|
Just tried it 14be76e |
|
We should remove the version bumps too. |
|
Fair point, pushing a fix |
|
That worked, thanks @uranusjr |
|
Failing test is unrelated |
|
Thanks for the fix @amoghrajesh. @kaxil wish to check if this would be included in 3.1.2 (not sure if we're still planning to cut one before you go on leave :))? Today, I observed with my local development efforts that upon installing Cosmos on 3.1.1 as base image, somehow |
|
Yup, this will be part of 3.1.2. Has been chery-picked already to v3-1-test |
|
Wow so sorry for that! To add some context from the structlog side: Styles wasn't really a thing – it was a hack to make the old-style class-variables-as-storage work as a type hint (I mean, what does Since you've already fixed it, I don't think it makes any sense to do any emergency releases form my side. Again, I'm sorry. |
|
All good, @hynek! I do not think any other project would've suffered it but we certainly did because |
Structlog released 25.5.0 version where
structlog.dev.Styleswas renamed asstructlog.dev.ColumnStylesalong with some refactoring. This breaks our CI like this:Move structlog imports into a TYPE_CHECKING block to untie version bumps
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.