Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Nov 4, 2025

The model property data from callback mismatches its DB schema definition. This property should be nullable. This is reported by the test test_database_schema_and_sqlalchemy_model_are_in_sync when SQLA2 is used. This test is failing in #56212 and I fixed it and now cherry-picking from there.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck requested review from XD-DENG and ashb as code owners November 4, 2025 19:38
@vincbeck vincbeck requested a review from ferruzzi November 4, 2025 19:38
@ramitkataria
Copy link
Contributor

This was my mistake 😅 I changed data from nullable to non-nullable but forgot to change it in the migration script. It is supposed to be non-nullable. There was another issue (about setting primary key constraint) I found in the 91 migration script so I can create a PR to fix both issues if you'd like

@ramitkataria
Copy link
Contributor

I created this PR: 57836

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to block accidental merge. See Ramit's comments above.

uranusjr
uranusjr previously approved these changes Nov 5, 2025
@uranusjr uranusjr dismissed their stale review November 5, 2025 02:20

The other PR is better

@vincbeck
Copy link
Contributor Author

vincbeck commented Nov 5, 2025

Closing this one in favor of #57836

@vincbeck vincbeck closed this Nov 5, 2025
@vincbeck vincbeck deleted the vincbeck/callback_nullable branch January 9, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants