Fix PK constraint setting + nullable mismatch in callback migration #57836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In some databases like MySQL, setting the primary key constraint while adding the column seems to not work as expected. So, this fixes that by setting the primary key constraint after the column creation statement. - There was a mismatch in the nullable property of the `data` column in the callback model. This sets the property to be non-nullable in both the migration script and the model.
ramitkataria
requested review from
XD-DENG,
ashb and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:db-migrations
This was referenced Nov 5, 2025
uranusjr
reviewed
Nov 5, 2025
airflow-core/src/airflow/migrations/versions/0091_3_2_0_restructure_callback_table.py
Show resolved
Hide resolved
uranusjr
approved these changes
Nov 5, 2025
vincbeck
approved these changes
Nov 5, 2025
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…pache#57836) - In some databases like MySQL, setting the primary key constraint while adding the column seems to not work as expected. So, this fixes that by setting the primary key constraint after the column creation statement. - There was a mismatch in the nullable property of the `data` column in the callback model. This sets the property to be non-nullable in both the migration script and the model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datacolumn in the callback model. This sets the property to be non-nullable in both the migration script and the model.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.