Skip to content

Enable ruff PLW0603 rule #58116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jscheffl wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable ruff PLW0603 rule #58116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0473754
Enable ruff PLW0603 rule
jscheffl Nov 9, 2025
961670b
Exclude check for global in airflow_local_settings.py
jscheffl Dec 25, 2025
b0ca4a7
Exclude one global in configuration.py
jscheffl Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/config_templates/airflow_local_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def _default_conn_name_from(mod_path, hook_name):
# Try to set the default conn name from a hook, but don't error if something goes wrong at runtime
from importlib import import_module

global DEFAULT_REMOTE_CONN_ID
global DEFAULT_REMOTE_CONN_ID # noqa: PLW0603

try:
mod = import_module(mod_path)
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ def load_standard_airflow_configuration(airflow_config_parser: AirflowConfigPars
:param airflow_config_parser: parser to which the configuration will be loaded

"""
global AIRFLOW_HOME # to be cleaned in Airflow 4.0
global AIRFLOW_HOME # noqa: PLW0603 # to be cleaned in Airflow 4.0
log.info("Reading the config from %s", AIRFLOW_CONFIG)
airflow_config_parser.read(AIRFLOW_CONFIG)
if airflow_config_parser.has_option("core", "AIRFLOW_HOME"):
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,7 @@ extend-select = [
"PLW0245", # super call is missing parentheses
"PLW0406", # Module {name} imports itself
"PLW0602", # Using global for {name} but no assignment is done
"PLW0603", # Using the global statement to update {name} is discouraged
"PLW0604", # global at module level is redundant
"PLW0642", # Reassigned {} variable in {method_type} method
"PLW0711", # Exception to catch is the result of a binary and operation
Expand Down
Loading