-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Enable ruff PLW0603 rule #58116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jscheffl
wants to merge
3
commits into
apache:main
Choose a base branch
from
jscheffl:feature/add-ruff-plw0603-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enable ruff PLW0603 rule #58116
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
261bb32 to
e089c28
Compare
This was referenced Nov 23, 2025
e089c28 to
6edc3e5
Compare
6edc3e5 to
65e4979
Compare
This was referenced Nov 29, 2025
65e4979 to
bf02e43
Compare
This was referenced Dec 3, 2025
bf02e43 to
076b3d8
Compare
This was referenced Dec 21, 2025
076b3d8 to
50e5c35
Compare
This was referenced Dec 23, 2025
50e5c35 to
0515f26
Compare
1 task
0515f26 to
b0ca4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1641
See also https://docs.astral.sh/ruff/rules/#warning-plw
NOTE: This is a DRAFT to see and continously rebase which things of
globalstatements are still open to clean