Remove global from FastAPI app.py #59772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
bugfix/remove-global-from-fastapi-app
branch
from
0e1403c to
dae543d
Compare
jscheffl
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
shahar1
approved these changes
Dec 24, 2025
jason810496
approved these changes
Dec 25, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
* Remove global from FastAPI app.py * Remove global from FastAPI app.py
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Remove global from FastAPI app.py * Remove global from FastAPI app.py
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Remove global from FastAPI app.py * Remove global from FastAPI app.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116
This removes global statement from
app.pywhere the FastAPI application instance and the current Auth Manager were stored as global, smelled a bit like a public interfaces which it should not. Using functools.cache() to prevent usage of global variables.globalis evil.