Remove global in configuration.py #59819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
commented
Dec 26, 2025
jscheffl
added
full tests needed
jscheffl
force-pushed
the
bugfix/remove-global-from-configuration
branch
from
336bbeb to
bb130be
Compare
jscheffl
changed the title
potiuk
reviewed
Dec 27, 2025
potiuk
approved these changes
Dec 27, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116
This removes (most of the) global statements from configuration.py where the JWT and FERNET key were hold, smelled a bit like a public interfaces which it should not. Using a private container class to prevent usage of global variables.
The leftover
AIRFLOW_HOMEis marked deprecated so in this case I'd rather exclude from future PLW0603 checksglobalis evil.