Bugfix/remove global from breeze #58866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
amoghrajesh
reviewed
Nov 30, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@jscheffl I think this one can be done much cleaner using function attributes: https://www.pythonmorsels.com/storing-attributes-on-functions-in-python/
jscheffl
force-pushed
the
bugfix/remove-global-from-breeze
branch
from
d80adca to
46ff0be
Compare
Contributor
Author
Okay, good idea. At least for "ci_group" made this as feedback. For the others I think it is not making it better. Unfortunately the WDYT? |
potiuk
approved these changes
Nov 30, 2025
Member
|
Looks great! we can improve it in the future if we find a better way. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2025
* Remove global from breeze modules * Remove global from breeze modules * Review feedback, use function attributes (cherry picked from commit fc70635) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Backport successfully created: v3-1-test
|
potiuk
pushed a commit
that referenced
this pull request
Nov 30, 2025
amoghrajesh
reviewed
Dec 1, 2025
Comment on lines
-54
to
+51
| global _in_ci_group | ||
| if _in_ci_group or skip_group_output(): | ||
| if getattr(ci_group, "__in_ci_group__", False) or skip_group_output(): |
Contributor
There was a problem hiding this comment.
Perfect @jscheffl! This is what I was suggesting
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
* Remove global from breeze modules * Remove global from breeze modules * Review feedback, use function attributes
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Remove global from breeze modules * Remove global from breeze modules * Review feedback, use function attributes
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* Remove global from breeze modules * Remove global from breeze modules * Review feedback, use function attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116
This removes all leftover global statements in breeze. In most cases
globalwas mis-used for some minor flags.globalis evil. Also in breeze :-D