Remove global from logging_config #59763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
amoghrajesh,
ashb,
kaxil and
o-nikolas
as code owners
boring-cyborg
bot
added
area:logging
area:providers
area:task-sdk
provider:amazon
jscheffl
force-pushed
the
bugfix/remove-global-from-logging-config
branch
from
3d4cb22 to
9758588
Compare
amoghrajesh
approved these changes
Dec 24, 2025
Ankurdeewan
pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Dec 25, 2025
* Remove global from logging_config * Ups, fix file missed to commit * Fix some leftover imports
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Remove global from logging_config * Ups, fix file missed to commit * Fix some leftover imports
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Remove global from logging_config * Ups, fix file missed to commit * Fix some leftover imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116
This removes global statement from logging_config.py where some state was stored via global variables, smelled a bit like a public interfaces which it should not. Wrapping into a private class with a static field instead of global.
globalis evil.