Remove global from breeze testing commands #58854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jscheffl
removed
the
backport-to-v3-1-test
bugraoz93
approved these changes
Nov 29, 2025
jscheffl
added
the
backport-to-v3-1-test
Contributor
Author
|
Nah, maybe shouldbackport, just to keep breeze in sync even if maybe not needed on 3.1 branch... just to ensure maintainability... |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 60bf28d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
jscheffl
added a commit
to jscheffl/airflow
that referenced
this pull request
Nov 29, 2025
* Remove global from breeze testing commands * Make ShellParams hashable * Make ShellParams hashable * Make ShellParams hashable, fix (cherry picked from commit 60bf28d) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk
pushed a commit
that referenced
this pull request
Nov 30, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
* Remove global from breeze testing commands * Make ShellParams hashable * Make ShellParams hashable * Make ShellParams hashable, fix
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Remove global from breeze testing commands * Make ShellParams hashable * Make ShellParams hashable * Make ShellParams hashable, fix
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* Remove global from breeze testing commands * Make ShellParams hashable * Make ShellParams hashable * Make ShellParams hashable, fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116
This just removes some global statements in breeze for preventing redundant log dumping. Just using functools.cache()
globalis evil. Also in breeze :-D(No need to backport in my view)