[v3-1-test] Limit Python prek hooks to use Python 3.10 (#58439) #58458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have inline project metadata in the prek hooks, and that means that each of the scripts will use their own venv to roon. However Airflow code and libraries does not support Python 3.14 yet (and will not for quite a while - because our dependencies will need time to catch-up. In the meantime we have to limit prek hooks to not install Python 3.14. Actually in order to have good stability, we are fine to limiting EVERYONE to use Python 3.10 for prek. There are no real benefits from using a different Python version (except maybe a little speed but prek-hooks are generally rather fast anyway) and we can definitely benefit from better stability and having exactly the same output for prek hooks by everyone. Uv will handle installation of the right python version automatically. (cherry picked from commit d31e578) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Fixes: #56048
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
We have inline project metadata in the prek hooks, and that means that each of the scripts will use their own venv to roon. However Airflow code and libraries does not support Python 3.14 yet (and will not for quite a while - because our dependencies will need time to catch-up. In the meantime we have to limit prek hooks to not install Python 3.14. Actually in order to have good stability, we are fine to limiting EVERYONE to use Python 3.10 for prek. There are no real benefits from using a different Python version (except maybe a little speed but prek-hooks are generally rather fast anyway) and we can definitely benefit from better stability and having exactly the same output for prek hooks by everyone. Uv will handle installation of the right python version automatically. (cherry picked from commit d31e578) Fixes: #56048 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
We have inline project metadata in the prek hooks, and that means that each of the scripts will use their own venv to roon. However Airflow code and libraries does not support Python 3.14 yet (and will not for quite a while - because our dependencies will need time to catch-up. In the meantime we have to limit prek hooks to not install Python 3.14. Actually in order to have good stability, we are fine to limiting EVERYONE to use Python 3.10 for prek. There are no real benefits from using a different Python version (except maybe a little speed but prek-hooks are generally rather fast anyway) and we can definitely benefit from better stability and having exactly the same output for prek hooks by everyone. Uv will handle installation of the right python version automatically. (cherry picked from commit d31e578) Fixes: #56048 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
We have inline project metadata in the prek hooks, and that means that each of the scripts will use their own venv to roon. However Airflow code and libraries does not support Python 3.14 yet (and will not for quite a while - because our dependencies will need time to catch-up. In the meantime we have to limit prek hooks to not install Python 3.14. Actually in order to have good stability, we are fine to limiting EVERYONE to use Python 3.10 for prek. There are no real benefits from using a different Python version (except maybe a little speed but prek-hooks are generally rather fast anyway) and we can definitely benefit from better stability and having exactly the same output for prek hooks by everyone. Uv will handle installation of the right python version automatically. (cherry picked from commit d31e578) Fixes: #56048 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
We have inline project metadata in the prek hooks, and that means that each of the scripts will use their own venv to roon. However Airflow code and libraries does not support Python 3.14 yet (and will not for quite a while - because our dependencies will need time to catch-up. In the meantime we have to limit prek hooks to not install Python 3.14. Actually in order to have good stability, we are fine to limiting EVERYONE to use Python 3.10 for prek. There are no real benefits from using a different Python version (except maybe a little speed but prek-hooks are generally rather fast anyway) and we can definitely benefit from better stability and having exactly the same output for prek hooks by everyone. Uv will handle installation of the right python version automatically. (cherry picked from commit d31e578) Fixes: #56048 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have inline project metadata in the prek hooks, and that means
that each of the scripts will use their own venv to roon. However
Airflow code and libraries does not support Python 3.14 yet (and will
not for quite a while - because our dependencies will need time to
catch-up. In the meantime we have to limit prek hooks to not install
Python 3.14.
Actually in order to have good stability, we are fine to limiting
EVERYONE to use Python 3.10 for prek. There are no real benefits from
using a different Python version (except maybe a little speed but
prek-hooks are generally rather fast anyway) and we can definitely
benefit from better stability and having exactly the same output
for prek hooks by everyone. Uv will handle installation of the
right python version automatically.
(cherry picked from commit d31e578)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Fixes: #56048