Deferred KubernetesPodOperator pushes XCom on successful execution.

[AutomationDev85]

Overview

After upgrading to kubernetes provider 10.10.0, XCom was no longer pushed on successful execution of KubernetesPodOperator in deferrable mode. This PR restores XCom propagation for successful deferred runs.

Change Summary

• Ensure trigger_reentry returns XCom value when do_xcom_push is True and execution succeeds.
• Extend unit tests to assert XCom is returned in deferrable mode.

Feedback is welcome.

[johnslavik]

This could be illegal syntax in a future Python version. We'll need to take that return out of finally.
https://peps.python.org/pep-0765/

[jscheffl]

@AutomationDev85 the more I revisit the core the more I think this patch was not good. Actually you wanted to push XCom but with this you are masking the exception raise.

Can you re-work? I assume you to manually xcom_push() and then raise in case of error, else return XCom in this way only on success but not in finally.

[AutomationDev85]

@johnslavik thanks for identifying this issue!! I created a PR to fix this issue: #58998

[jscheffl]

I assume cause is that the ruff rule https://docs.astral.sh/ruff/rules/return-in-try-except-finally/ (SIM107) is not enabled in the repo, that should have catched this. Will put this on my bucket list to enable... or if somebody else wants to make a PR I assume this is an important check we are missing atm.

[johnslavik]

Will put this on my bucket list to enable... or if somebody else wants to make a PR I assume this is an important check we are missing atm.

#59019

[potiuk]

Cool. Thanks @johnslavik !