Skip to content

Conversation

@AutomationDev85
Copy link
Contributor

Overview

PR #58488 introduced returning XCom from the finally block. Thanks to @johnslavik for identifying the issue.

Change Summary

  • Remove the return from the finally block and use xcom_push to emit the XCom.
  • Update unit tests accordingly.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jscheffl
Copy link
Contributor

jscheffl commented Dec 3, 2025

@johnslavik I saw you reacted on the PR, happy to invite you for review. If you think it is good, please also approve (even though as a non-committer this is an indicative signal it helps the other committers)

@jscheffl
Copy link
Contributor

jscheffl commented Dec 3, 2025

I leave the PR open for 1-2 days for other eyes to review but in my view can be merged and is a good fix.

@johnslavik
Copy link
Contributor

@johnslavik I saw you reacted on the PR, happy to invite you for review.

Thanks! Sorry, but I'm currently not able to review this -- I haven't grasped this part of Airflow yet.

@jscheffl jscheffl merged commit d96ff62 into apache:main Dec 7, 2025
97 checks passed
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Dec 8, 2025
Co-authored-by: AutomationDev85 <AutomationDev85>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants