refactor: move task stream filtering logic to endpoint for Grid #58576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarLigthart
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
OscarLigthart
force-pushed
the
refactor/move-task-filtering-logic-to-endpoints
branch
from
2ca6130 to
fed6a07
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, thanks for the pull request. 🎉
Do you mind updating the tests for the backend endpoint (structure), for these newly added query parameters? (with a few different combinations)
OscarLigthart
force-pushed
the
refactor/move-task-filtering-logic-to-endpoints
branch
2 times, most recently
from
92c71db to
cdfa245
Compare
Contributor
Author
Great point 👍 Adding the test actually showed me that I forgot to account for the retrieval of historical tasks. To make the code a bit clearer, I moved that part to I thought it would make sense to refrain from retrieving historical tasks in case of filtering the DAG. Let me know whether you agree or not! |
OscarLigthart
force-pushed
the
refactor/move-task-filtering-logic-to-endpoints
branch
from
32b6a76 to
0295804
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good.
Just one question to clarify before we can merge.
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
Outdated
Show resolved
Hide resolved
OscarLigthart
force-pushed
the
refactor/move-task-filtering-logic-to-endpoints
branch
6 times, most recently
from
9f13179 to
5efe698
Compare
OscarLigthart
force-pushed
the
refactor/move-task-filtering-logic-to-endpoints
branch
from
5efe698 to
2752bfb
Compare
pierrejeambrun
approved these changes
Dec 18, 2025
Member
|
Thanks @OscarLigthart! 🎉 |
Lohith625
pushed a commit
to Lohith625/airflow
that referenced
this pull request
Dec 19, 2025
…he#58576) * refactor: move task stream filtering logic to endpoint for Grid * fix: lint * feat: add tests for stream filter in grid * fix: historical task filtering * fix: return value for collect_historical_tasks * fix: remove duplicate historical task retrieval and add historical task to test case
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…he#58576) * refactor: move task stream filtering logic to endpoint for Grid * fix: lint * feat: add tests for stream filter in grid * fix: historical task filtering * fix: return value for collect_historical_tasks * fix: remove duplicate historical task retrieval and add historical task to test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #57237, @bbovenzi gave me a piece of feedback that we should try to avoid fetching all of the tasks a second time and then iterating through them all again on the frontend. Instead, we should add the filter parameters to the existing grid structure endpoint. Keeping scopes of PRs small, I decided to do it in separate PR.
Enter this PR, which introduces exactly that. It simplifies the frontend Grid behaviour in favour of implementing the filter logic in the backend.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.