Use filelock to fix race condition in version suffix test for xdist runs #58608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
approved these changes
Nov 24, 2025
uranusjr
reviewed
Nov 24, 2025
Backport successfully created: v3-1-test
|
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…uns (apache#58608) * Use filelock to fix race condition in version suffix test for xdist runs * Use filelock to fix race condition in version suffix test for xdist runs
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…uns (apache#58608) * Use filelock to fix race condition in version suffix test for xdist runs * Use filelock to fix race condition in version suffix test for xdist runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to fix a breeze test in #58593 and tried eliminating race condition for xdist runs through that fix, but that fix isn't good enough. Mentioned here: #58593 (comment)
Instead, we could use a file lock by
filelocklibrary to retrieve a lock and run the critical section code that patches the toml file version to not unnecessarily mock and achieve more of an integration test behavior than mocking and not catching the issue. Used filelock library for this: https://py-filelock.readthedocs.io/en/latest/index.html which provides a platform independent file lock that will be a one stop solution for our runs.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.