Fix .airflowignore negation patterns for subdirectories #58737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes negation patterns in
.airflowignorenot working for subdirectories whenusing glob syntax.
From docs;
Taken from #58636:
With the above setup, only
dag.pyandsubdir/dag.pyare included. Fileslike
ignored.pyandsubdir/ignored.pyand the rest stays ignored.Previously, the
*pattern would match and prunesubdirbefore the negationpatterns could be evaluated.
The fix checks if any negation pattern exists in the rules. If a directory
would be ignored but there are negation patterns, the directory is not pruned,
allowing file-level matching to decide what gets included.
Closes: #58636
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.