-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix airflowignore negation does not work in subfolders #58740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, but we'll need to resolve the CI failure before the next round review |
9008e27 to
d7d836f
Compare
Yep. |
d7d836f to
1566104
Compare
1566104 to
2f4ec69
Compare
|
Hi @henry3260, in which airflow version will this be released? Noticed that this is merged with main but not part of the recent airflow 3.1.4 release. |
…pache#58740) (cherry picked from commit 33cb64a) Co-authored-by: Henry Chen <108824346+henry3260@users.noreply.github.com>
We miss backporting it. I just did #59305. most likely 3.1.5 |
|
Hi @Lee-W, I dont see this in the airflow 3.1.5 source code despite the milestone set as 3.1.5. |
3.1.4 was yanked due to an accidental release mistake, and 3.1.5 is essentially 3.1.4rc2. Thus, we did not add anything to 3.1.5 / 3.1.4rc2. This will be added to 3.1.6 instead |
Closes: #58636
From docs;
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dags.html#airflowignore
https://git-scm.com/docs/gitignore
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.